Properly deprecate edd plugin updater code, remove FrmDeprecated class and old page_route example

[Crabcyborg]

Nothing in this code was really calling _deprecated_function.

For now I've stripped out the majority of the code, but left the functions in-place with deprecated warnings.

[coderabbitai]

Walkthrough

The pull request involves a significant refactoring of the FrmEDD_SL_Plugin_Updater class, focusing on the complete deprecation of its methods and properties. Key methods, including the constructor and several functional methods, have been marked as deprecated, with their internal logic removed. Additionally, the FrmAppController class has seen the removal of a deprecated method and the introduction of a new private method. The FrmDeprecated class has been entirely removed, alongside its method. Lastly, the phpstan.neon configuration has been updated to exclude the deprecated file from scanning.

Changes

File	Change Summary
deprecated/FrmEDD_SL_Plugin_Updater.php	- Deprecated methods: __construct(), init(), check_update(), plugins_api_filter(), http_request_args(), get_cached_version_info(), set_version_info_cache(), verify_ssl(). - Removed internal logic for all deprecated methods.
classes/controllers/FrmAppController.php	- Removed deprecated method: page_route(). - Added new private method: in_our_pages().
deprecated/FrmDeprecated.php	- Removed class: FrmDeprecated. - Removed method: page_route().
phpstan.neon	- Removed scanFiles entry for - deprecated/FrmDeprecated.php.

Possibly related PRs

• Add a null check to avoid deprecated message when previewing #1742: This PR addresses deprecated messages related to previewing, which may connect to the overall theme of deprecation in the main PR.
• Drop IP warning from settings #2062: This PR involves the removal of deprecated IP warnings, aligning with the main PR's focus on deprecating methods and properties.
• Drop deprecated support for string where value in generate_query_stri… #2059: This PR removes deprecated support for a string parameter, which is related to the main PR's emphasis on deprecating functionality.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9a347bc and b558966.

📒 Files selected for processing (3)

• classes/controllers/FrmAppController.php (0 hunks)
• deprecated/FrmDeprecated.php (0 hunks)
• phpstan.neon (0 hunks)

💤 Files with no reviewable changes (3)

• classes/controllers/FrmAppController.php
• deprecated/FrmDeprecated.php
• phpstan.neon

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 2056fa6 and 9a347bc.

📒 Files selected for processing (1)

• deprecated/FrmEDD_SL_Plugin_Updater.php (5 hunks)