Temporarily remove input shortcodes when rendering forms fix#2101
Conversation
WalkthroughThe changes introduce a mechanism in the form rendering process to temporarily remove the Changes
Possibly related PRs
Warning Rate limit exceeded@Crabcyborg has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 24 minutes and 4 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (1)
classes/views/frm-entries/form.php (1)
Line range hint
6-156: Consider a more robust long-term solution.While temporarily removing the shortcode works as a quick fix, consider these long-term solutions:
- Use a more specific shortcode name (e.g.,
[frm_input]) to avoid conflicts- Implement proper namespacing for shortcodes
- Coordinate with the Paystack plugin team to resolve the conflict at its source
This would provide a more maintainable solution and prevent similar conflicts in the future.
Would you like help drafting a proposal for any of these alternative approaches?
Crabcyborg
deleted the
temporary_remove_input_shortcodes_when_rendering_forms_fix
branch
1 participant
Related Slack conversation https://strategy11.slack.com/archives/C799A2R61/p1731506429943149
Payment forms by Paystack has a global
inputshortcode, which is a pretty horrible practice 😅.This update unregisters
[input]before we render our form fields which rely on this internal shortcode. Then we re-apply it back after so it doesn't break Paystack.