Skip to content

Prepare for 6.16.1 #2102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 5 commits into from
Nov 13, 2024
Merged

Prepare for 6.16.1 #2102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
050c08e
Add two additional change log entries
Crabcyborg Nov 13, 2024
c87f315
Update since versions
Crabcyborg Nov 13, 2024
485b5d0
Prepare for v6.16.1
Crabcyborg Nov 13, 2024
367d4bc
Merge branch 'master' into prepare_for_6.16.1
Crabcyborg Nov 13, 2024
7ad801f
Update pot file again
Crabcyborg Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
== Changelog ==
= 6.16.1 =
* New: Database queries for entry ID data have been optimized, removing a JOIN in cases where it is not required. This should significantly improve performance when searching for entries in a View.
* Fix: Collapsible sections in the styler settings would no longer open after the recent WordPress 6.7 update.
* Fix: The label position setting and CSS layout classes for summary fields were not working. Since None is also the default value for Summary field label positions, this means that Summary field labels that previously were visible likely are no longer visible.
* Fix: The slider to set field margin for section fields wouldn't properly save.
* Fix: Checkbox selection would not work on iPhones when using frm_grid classes.
Expand All @@ -9,6 +10,7 @@
* Fix: Stripe payments using the action included in this plugin would fail to initialize when using shortcode amount values for many currency types including Mexican Pesos.
* Fix: An array to string conversion PHP warning has been fixed.
* Fix: The center form styling toggle would not properly save.
* Fix: Form fields would appear broken when the Payment forms by Paystack plugin was active due to a shortcode conflict.
* Several deprecated functions have been removed including FrmAppController::page_route, FrmFieldType::default_invalid_msg, FrmFieldType::default_unique_msg, FrmStylesHelper::maybe_include_font_icon_css, FrmFormsHelper::ignore_template_categories, FrmFormActionsHelper::default_action_opts, and FrmAppHelper::maybe_full_screen_link.
* The unused FrmEDD_SL_Plugin_Updater class has been deprecated and is no longer functional.

Expand Down
12 changes: 6 additions & 6 deletions classes/controllers/FrmUsageController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class FrmUsageController {
/**
* Option name of flows data.
*
* @since x.x
* @since 6.16.1
*
* @var string
*/
Expand Down Expand Up @@ -69,7 +69,7 @@ public static function send_snapshot() {
/**
* Loads scripts.
*
* @since x.x
* @since 6.16.1
*/
public static function load_scripts() {
if ( self::is_forms_list_page() || FrmAppHelper::is_admin_page( 'formidable-form-templates' ) ) {
Expand All @@ -80,7 +80,7 @@ public static function load_scripts() {
/**
* Checks if is forms list page.
*
* @since x.x
* @since 6.16.1
*
* @return bool
*/
Expand All @@ -102,7 +102,7 @@ private static function is_forms_list_page() {
/**
* AJAX handler to track flows.
*
* @since x.x
* @since 6.16.1
*/
public static function ajax_track_flows() {
FrmAppHelper::permission_check( 'frm_view_forms' );
Expand All @@ -119,7 +119,7 @@ public static function ajax_track_flows() {
/**
* Updates flows data.
*
* @since x.x
* @since 6.16.1
*
* @param string $key Flow key.
* @param string $value Flow value.
Expand Down Expand Up @@ -148,7 +148,7 @@ public static function update_flows_data( $key, $value ) {
/**
* Get flows data.
*
* @since x.x
* @since 6.16.1
*
* @return array
*/
Expand Down
4 changes: 2 additions & 2 deletions classes/helpers/FrmAppHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class FrmAppHelper {
*
* @var string
*/
public static $plug_version = '6.16';
public static $plug_version = '6.16.1';

/**
* @var bool
Expand Down Expand Up @@ -2111,7 +2111,7 @@ public static function array_flatten( $array, $keys = 'keep' ) {
/**
* Flatten an array before imploding it to avoid Array to string conversion warnings.
*
* @since x.x
* @since 6.16.1
*
* @param string $sep
* @param array $array
Expand Down
2 changes: 1 addition & 1 deletion classes/helpers/FrmFormsHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1127,7 +1127,7 @@ public static function edit_form_link( $data ) {
/**
* Returns a text used when no title is set.
*
* @since x.x
* @since 6.16.1
*
* @return string
*/
Expand Down
2 changes: 1 addition & 1 deletion classes/models/FrmEntryMeta.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ public static function get_top_level_entry_ids( $query, $args ) {
* Returns true if the where clause refers to a field table column that is not form_id. It also updates
* the where clause to refer to the entry table for form_id if fields table should not be joined.
*
* @since x.x
* @since 6.16.1
* @param array|string $where
* @return bool
*/
Expand Down
4 changes: 2 additions & 2 deletions classes/models/FrmUsage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public function snapshot() {
/**
* Gets onboarding wizard data.
*
* @since x.x
* @since 6.16.1
*
* @return array
*/
Expand All @@ -131,7 +131,7 @@ private function onboarding_wizard() {
/**
* Gets payments data.
*
* @since x.x
* @since 6.16.1
*
* @param string $table Database table name.
* @return array
Expand Down
16 changes: 8 additions & 8 deletions deprecated/FrmEDD_SL_Plugin_Updater.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class FrmEDD_SL_Plugin_Updater {
* @param array $_api_data Optional data to send with API calls.
*/
public function __construct( $_api_url, $_plugin_file, $_api_data = array() ) {
_deprecated_function( __METHOD__, 'x.x' );
_deprecated_function( __METHOD__, '6.16.1' );
}

/**
Expand All @@ -35,7 +35,7 @@ public function __construct( $_api_url, $_plugin_file, $_api_data = array() ) {
* @return void
*/
public function init() {
_deprecated_function( __METHOD__, 'x.x' );
_deprecated_function( __METHOD__, '6.16.1' );
}

/**
Expand All @@ -53,15 +53,15 @@ public function init() {
* @return stdClass Modified update array with custom plugin data.
*/
public function check_update( $_transient_data ) {
_deprecated_function( __METHOD__, 'x.x' );
_deprecated_function( __METHOD__, '6.16.1' );
if ( ! is_object( $_transient_data ) ) {
$_transient_data = new stdClass();
}
return $_transient_data;
Comment on lines +56 to 60
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider adding warning logs for deprecated method calls

The deprecated methods are returning dummy values which could lead to silent failures. Consider adding warning logs to help developers identify usage of deprecated functionality during development/testing.

Example implementation:

 public function check_update( $_transient_data ) {
 		_deprecated_function( __METHOD__, '6.16.1' );
+		trigger_error( 'Using deprecated update checker. Please update your implementation.', E_USER_WARNING );
 		if ( ! is_object( $_transient_data ) ) {
 			$_transient_data = new stdClass();
 		}
 		return $_transient_data;
 }

Also applies to: 74-76, 87-89, 95-97, 100-101

}

/**
* Updates information on the "View version x.x details" page with custom data.
* Updates information on the "View version 6.16.1 details" page with custom data.
*
* @uses api_request()
*
Expand All @@ -71,7 +71,7 @@ public function check_update( $_transient_data ) {
* @return object $_data
*/
public function plugins_api_filter( $_data, $_action = '', $_args = null ) {
_deprecated_function( __METHOD__, 'x.x' );
_deprecated_function( __METHOD__, '6.16.1' );
return $_data;
}

Expand All @@ -84,20 +84,20 @@ public function plugins_api_filter( $_data, $_action = '', $_args = null ) {
* @return array $array
*/
public function http_request_args( $args, $url ) {
_deprecated_function( __METHOD__, 'x.x' );
_deprecated_function( __METHOD__, '6.16.1' );
return $args;
}

public function show_changelog() {
}

public function get_cached_version_info( $cache_key = '' ) {
_deprecated_function( __METHOD__, 'x.x' );
_deprecated_function( __METHOD__, '6.16.1' );
return false;
}

public function set_version_info_cache( $value = '', $cache_key = '' ) {
_deprecated_function( __METHOD__, 'x.x' );
_deprecated_function( __METHOD__, '6.16.1' );
}

}
2 changes: 1 addition & 1 deletion formidable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
/**
* Plugin Name: Formidable Forms
* Description: Quickly and easily create drag-and-drop forms
* Version: 6.16
* Version: 6.16.1
* Plugin URI: https://formidableforms.com/
* Author URI: https://formidableforms.com/
* Author: Strategy11 Form Builder Team
Expand Down
Loading