fix textarea default value in multipage forms

[engahmeds3ed]

Fixes https://github.com/Strategy11/formidable-pro/issues/5470

We validated the fix in the customer's site and it's working properly.

[coderabbitai]

Walkthrough

The pull request modifies the front_field_input method of the FrmFieldTextarea class in the FrmFieldTextarea.php file. The update changes how the textarea's value is determined by introducing a check for an empty value, allowing a fallback to a default value if necessary. The show_on_form_builder method remains unchanged, and other methods in the class are unaffected by this change.

Changes

File	Change Summary
classes/models/fields/FrmFieldTextarea.php	Modified front_field_input method to use $this->field['default_value'] when $this->field['value'] is empty.

Possibly related PRs

• Fix submit button auto order change #2085: The changes in the FrmForm class's prepare_field_update_values method and the FrmFormsController class's create_submit_button_field method involve logic related to field handling, which may indirectly relate to how fields, including textareas, are managed in forms.

Suggested labels

run analysis, run tests

Suggested reviewers

• truongwp
• lauramekaj1
• Crabcyborg

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 655510c and 1825d5f.

📒 Files selected for processing (1)

• classes/models/fields/FrmFieldTextarea.php (1 hunks)

🔇 Additional comments (1)

classes/models/fields/FrmFieldTextarea.php (1)

97-97: LGTM! Good solution for handling empty textarea values.

The change correctly implements a fallback mechanism to use the default value when the field value is empty. This fix:

1. Maintains proper escaping for security
2. Uses an appropriate empty check
3. Preserves the existing functionality while adding the fallback
4. Solves the issue with textarea default values in multipage forms

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Crabcyborg]

Thanks @engahmeds3ed.

Unfortunately these sorts of issues are a bit more complex.

This code is also used if I'm editing an entry for example with no value. It will show the default even though I had previously put nothing. There's other code that sets $this->field['value'] to the default, and other code that clears these values when conditionally hidden. We have some JS that restores default values when a field is shown again. When the field isn't visible, we want it to have no value. We generally fix these sorts of issues a bit differently.

We have a few similar issues that we need to figure out still.

• https://github.com/Strategy11/formidable-pro/issues/4081
• https://github.com/Strategy11/formidable-pro/issues/4110

The ! empty also wouldn't be totally safe since it would break 0 values.

I plan to try looking further into this.

[Crabcyborg]

Closing this for now as I don't think we'll be going in this direction. I think the fix will likely be in Pro code since this issue isn't related to Lite either.