Add free not first 30 inbox target

[Crabcyborg]

No description provided.

[coderabbitai]

Walkthrough

The changes in the FrmInbox class within FrmInbox.php involve the addition of several private methods to enhance message filtering and categorization based on user types and subscription status. New methods is_for_everyone, is_user_type, is_free_not_first_30, and is_free have been introduced, while existing methods have been refactored for improved readability. The logic for determining message visibility has been clarified, and documentation comments have been updated to reflect these changes.

Changes

File Path	Change Summary
classes/models/FrmInbox.php	- Added methods: is_for_everyone($who), is_user_type($who), is_free_not_first_30(), is_free()
	- Updated method signature: is_free_first_30() to call is_free() and is_first_30()
	- Added new method: is_first_30()
	- Refactored is_for_user to utilize new methods for improved logic clarity
	- Updated documentation comments for new methods and version history

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (3)

classes/models/FrmInbox.php (3)

236-254: Update @SInCE version tags

The @since x.x tags should be updated with the actual version number for these new methods.

---

412-422: Consider using a constant for the time period

The implementation is good, but consider extracting the '30 days' value into a class constant for better maintainability and reusability.

+ private const TRIAL_PERIOD_DAYS = 30;

  private function is_first_30() {
      $activation_timestamp = get_option( 'frm_first_activation' );
      if ( false === $activation_timestamp ) {
          return false;
      }
-     $cutoff = strtotime( '-30 days' );
+     $cutoff = strtotime( '-' . self::TRIAL_PERIOD_DAYS . ' days' );
      return $activation_timestamp > $cutoff;
  }

---

423-441: Update @SInCE version tags and LGTM!

The implementation is clean and follows good practices. Just update the @since x.x tags with the actual version number.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 0914679 and 513834d.

📒 Files selected for processing (1)

• classes/models/FrmInbox.php (3 hunks)

🔇 Additional comments (2)

classes/models/FrmInbox.php (2)

212-223: LGTM! Clean implementation of new user type checks.

The additional conditions for user type verification maintain good readability and follow the existing pattern. The code effectively delegates specific checks to dedicated helper methods.

---

404-405: LGTM! Good refactoring.

The method has been cleanly refactored to use the new helper methods, improving code reusability and maintainability.