Add more global settings to usage tracking#2142
Conversation
WalkthroughThe changes in this pull request involve modifications to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant FrmUsage
participant Settings
User->>FrmUsage: Request tracking settings
FrmUsage->>Settings: Retrieve pass_settings
Settings-->>FrmUsage: Return pass_settings with custom_header_ip, summary_emails, active_captcha
FrmUsage-->>User: Provide updated tracking settings
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)classes/models/FrmUsage.php (1)
The addition of Let's verify these settings exist in the codebase: ✅ Verification successfulAll settings are properly defined and used in the codebase The verification confirms that all three settings are properly integrated:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify the existence and usage of the new settings
# Search for settings definitions and usage
echo "Searching for custom_header_ip setting..."
rg "custom_header_ip" --type php
echo "Searching for summary_emails setting..."
rg "summary_emails" --type php
echo "Searching for active_captcha setting..."
rg "active_captcha" --type php
Length of output: 7528 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
truongwp
left a comment
There was a problem hiding this comment.
This looks good. We don't need to update the usage repo.
Thanks @Crabcyborg!
|
Awesome. Thanks Truong! |
While working on setting up some metabase examples, I noticed a few things we weren't tracking.
@truongwp This probably requires some changes in the other repo as well. I could use your help getting that updated.