Simplify some if conditions

[Crabcyborg]

No description provided.

[coderabbitai]

Walkthrough

The changes in this pull request primarily affect the FrmForm class within FrmForm.php. Modifications were made to the getAll and maybe_get_current_form methods, specifically altering the conditions for checking the is_template key and the current_form variable. The adjustments ensure that only non-empty values are considered for these checks, refining the logic for form retrieval and filtering based on template status and current form context.

Changes

File	Change Summary
classes/models/FrmForm.php	Modified conditions in getAll to check for non-empty is_template values; adjusted maybe_get_current_form to check if current_form is non-empty.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant FrmForm
    participant FormRepository

    User->>FrmForm: Request to get all forms
    FrmForm->>FormRepository: Retrieve forms with non-empty is_template
    FormRepository-->>FrmForm: Return filtered forms
    FrmForm-->>User: Return forms

    User->>FrmForm: Request current form
    FrmForm->>FormRepository: Check current_form (non-empty)
    FormRepository-->>FrmForm: Return current form
    FrmForm-->>User: Return current form

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between fbf00a5 and f1928a1.

📒 Files selected for processing (1)

• classes/models/FrmForm.php (3 hunks)

🔇 Additional comments (2)

classes/models/FrmForm.php (2)

Line range hint 852-856: LGTM: Improved template filtering logic

The condition correctly filters out trashed templates when retrieving template forms, ensuring only active templates are returned.

---

1094-1094: LGTM: Simplified conditions while maintaining logic

The conditions have been simplified:

1. Current form check now uses a cleaner empty check
2. CSS loading check uses a more straightforward condition structure

These changes align with the PR objective of simplifying if conditions.

Also applies to: 1143-1143

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.