Skip to content

New filter frm_recaptcha_verify_domain #2180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Crabcyborg wants to merge 1 commit into from
Closed

New filter frm_recaptcha_verify_domain #2180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion classes/models/FrmRecaptchaSettings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,19 @@ class FrmRecaptchaSettings extends FrmFieldCaptchaSettings {
* @return void
*/
protected function set_endpoint() {
$this->endpoint = 'https://www.google.com/recaptcha/api/siteverify';
$domain = 'https://www.google.com';

/**
* @since x.x
*
* @param string $domain
*/
$filtered_domain = apply_filters( 'frm_recaptcha_verify_domain', $domain );
if ( is_string( $filtered_domain ) ) {
$domain = $filtered_domain;
}

$this->endpoint = $domain . '/recaptcha/api/siteverify';
Comment on lines +17 to +29
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Add URL validation and trailing slash handling

The implementation should validate the filtered domain URL and handle trailing slashes to prevent malformed URLs.

Consider this improved implementation:

-		$domain = 'https://www.google.com';
+		$domain = 'https://www.google.com';
 
 		/**
 		 * @since x.x
 		 *
 		 * @param string $domain
 		 */
 		$filtered_domain = apply_filters( 'frm_recaptcha_verify_domain', $domain );
-		if ( is_string( $filtered_domain ) ) {
+		if ( is_string( $filtered_domain ) && filter_var( $filtered_domain, FILTER_VALIDATE_URL ) ) {
 			$domain = $filtered_domain;
 		}
 
-		$this->endpoint = $domain . '/recaptcha/api/siteverify';
+		$this->endpoint = rtrim($domain, '/') . '/recaptcha/api/siteverify';
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
$domain = 'https://www.google.com';
/**
* @since x.x
*
* @param string $domain
*/
$filtered_domain = apply_filters( 'frm_recaptcha_verify_domain', $domain );
if ( is_string( $filtered_domain ) ) {
$domain = $filtered_domain;
}
$this->endpoint = $domain . '/recaptcha/api/siteverify';
$domain = 'https://www.google.com';
/**
* @since x.x
*
* @param string $domain
*/
$filtered_domain = apply_filters( 'frm_recaptcha_verify_domain', $domain );
if ( is_string( $filtered_domain ) && filter_var( $filtered_domain, FILTER_VALIDATE_URL ) ) {
$domain = $filtered_domain;
}
$this->endpoint = rtrim($domain, '/') . '/recaptcha/api/siteverify';

}

/**
Expand Down