Remove more jQuery from field validation JS

[Crabcyborg]

No description provided.

[coderabbitai]

Walkthrough

The pull request introduces a new validateField function in the formidable.js file, focusing on improving form field validation using native JavaScript. The changes replace jQuery-dependent methods with more modern JavaScript approaches, enhancing the validation process by finding field containers, checking required fields, and managing error handling more efficiently.

Changes

File	Change Summary
js/formidable.js	- Added validateField function with native JavaScript implementation - Replaced jQuery methods with closest() and hasClass() - Improved error handling and field validation logic - Updated variable naming for clarity

Sequence Diagram

sequenceDiagram
    participant Form
    participant validateField
    participant Field
    participant ErrorHandling

    Form->>validateField: Invoke validation
    validateField->>Field: Find field container
    validateField->>Field: Check required status
    alt Field is required and invalid
        validateField->>ErrorHandling: Remove existing errors
        validateField->>ErrorHandling: Add new error messages
    else Field is valid
        validateField->>ErrorHandling: Clear errors
    end
    validateField-->>Form: Return validation result

Loading

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

js/formidable.js (2)

296-302: Consider documenting support for jQuery objects in the JSDoc.
Currently, the JSDoc specifies @param {HTMLElement} field, and the code invokes native DOM methods like closest(). However, elsewhere in the file, code can also work with jQuery objects. If this function is intended to receive a jQuery object in some scenarios, consider clarifying in the JSDoc, e.g. @param {HTMLElement|jQuery} field.

---

317-317: Consider consistently naming the field container variable.
You already have const fieldContainer at line 307 for the native DOM element. Naming the jQuery variable similarly (e.g. $fieldContainer) may reduce confusion over which variable is in use.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 200c761 and d23fa93.

📒 Files selected for processing (1)

• js/formidable.js (1 hunks)

🔇 Additional comments (2)

js/formidable.js (2)

304-305: No issues found.
These lines merely declare variables and maintain a clear separation of concerns.

---

309-309: Looks consistent with the required-field check.
This condition neatly ties into the checkRequiredField logic and ensures we skip secondary validation if a required-field error was found.