Update readme for v6.17#2212
Conversation
WalkthroughThis pull request introduces version 6.17 of the Formidable Forms plugin, focusing on enhancing functionality, performance, and validation. Key updates include new settings for redirect delay in confirmation actions, a UTF-8 with BOM option for CSV exports, and a new database index to improve field query performance. The changes also address validation improvements for email fields, refine HTML tag handling, and deprecate certain global JavaScript functions. Changes
Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
readme.txt (1)
377-378: Performance optimization for field queriesAdded a new database index to the fields table and optimized database queries, which should significantly improve performance for field-related operations.
Consider monitoring query performance after this change to ensure the index is being utilized effectively.
changelog.txt (1)
3-4: Performance improvement for field queriesThe addition of a database index to the fields table is a significant performance optimization that should improve query speed for field-related operations.
Consider monitoring query performance on large forms to verify the index is being utilized effectively.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
changelog.txt(1 hunks)readme.txt(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Cypress
🔇 Additional comments (6)
readme.txt (5)
374-375: Version 6.17 introduces several important improvementsThis release focuses on performance optimizations, security enhancements, and new features for better user experience.
375-376: New confirmation action settings improve UXAdded new redirect delay duration and delay message settings for confirmation actions, giving users more control over the post-submission experience.
Also applies to: 376-377
378-379: CSV export improvementsTwo notable CSV export enhancements:
- Added UTF-8 with BOM format option for better international character support
- Optimized database queries for non-Pro CSV exports
- Added batch size filter for fine-tuning export performance
Also applies to: 379-380
380-381: Enhanced email validationAdded additional validation for email fields to prevent incorrect period usage, improving data quality and security.
381-384: Bug fixes and improvementsSeveral important fixes:
- Updated Akismet name value checking to reduce false positives
- Improved HTML tag handling for form data input
- Fixed bottom margin value for centered submit buttons
- Deprecated global JS function frmFrontForm.escapeHtml
changelog.txt (1)
10-10: Security enhancement for HTML tag handlingThe updated HTML tag handling with conditional allowance provides better security while maintaining necessary functionality.
Run this script to check current HTML tag handling:
✅ Verification successful
HTML tag handling implementation verified as secure
The implementation uses WordPress's battle-tested sanitization functions (wp_kses_post and strip_tags) appropriately, with specific handling for edge cases where valid option values might contain HTML-like content.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check HTML tag handling in form data rg "strip_tags|wp_kses" --type phpLength of output: 6554
No description provided.