Lite Version: Fix number field step validation

[shervElmi]

Pro PR:
https://github.com/Strategy11/formidable-pro/pull/5618

[Crabcyborg]

Thanks @shervElmi!

[coderabbitai]

Walkthrough

The changes update the FrmFieldNumber class by modifying the visibility of the check_value_is_valid_with_step method from private to protected, permitting access from subclasses. Additionally, the error message formatting in the validate_step method now includes a check to confirm that values are numeric before converting them to floats. The overall class structure and core functionality remain unchanged.

Changes

File	Change Summary
classes/.../FrmFieldNumber.php	Updated check_value_is_valid_with_step method from private to protected; enhanced error message formatting in validate_step for numeric checking.

Suggested labels

action: needs qa

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 PHPStan (2.0.3)

/bin/bash: line 1: /vendor/bin/phpstan: No such file or directory

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b9e906a and 8a0ace1.

📒 Files selected for processing (1)

• classes/models/fields/FrmFieldNumber.php (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• classes/models/fields/FrmFieldNumber.php

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: PHP 8 tests in WP trunk
• GitHub Check: Cypress
• GitHub Check: PHP 7.4 tests in WP trunk

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 26.84%. Comparing base (f0337b4) to head (8a0ace1).
Report is 64 commits behind head on master.

Files with missing lines	Patch %	Lines
classes/models/fields/FrmFieldNumber.php	33.33%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2245      +/-   ##
============================================
+ Coverage     26.78%   26.84%   +0.06%     
+ Complexity     8328     8327       -1     
============================================
  Files           129      129              
  Lines         27511    27506       -5     
============================================
+ Hits           7368     7384      +16     
+ Misses        20143    20122      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.