Skip to content

Use less jquery when validating #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 2 commits into from
Feb 19, 2025
Merged

Use less jquery when validating #2252

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5710cb
Use less jquery when validating
Crabcyborg Feb 19, 2025
fcc8590
Clean up further
Crabcyborg Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions js/formidable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,7 @@ function frmFrontFormJS() {
* @return {Array} Errors.
*/
function validateForm( object ) {
let errors, n, nl, fields, field;

errors = [];
let errors = [];

const vanillaJsObject = 'function' === typeof object.get ? object.get( 0 ) : object;

Expand All @@ -201,10 +199,8 @@ function frmFrontFormJS() {
}
);

fields = jQuery( object ).find( 'input,select,textarea' );
if ( fields.length ) {
for ( n = 0, nl = fields.length; n < nl; n++ ) {
field = fields[n];
vanillaJsObject?.querySelectorAll( 'input,select,textarea' ).forEach(
field => {
if ( '' === field.value ) {
if ( 'number' === field.type ) {
// A number field will return an empty string when it is invalid.
Expand All @@ -215,14 +211,14 @@ function frmFrontFormJS() {
if ( ! isConfirmationField ) {
// Allow a blank confirmation field to still call validateFieldValue.
// If we continue for a confirmation field there are issues with forms submitting with a blank confirmation field.
continue;
return;
}
}

validateFieldValue( field, errors, true );
checkValidity( field, errors );
}
}
);

// Invisible captchas are processed after validation.
// We only want to validate a visible captcha on submit.
Expand Down