Fix up some action code

[Crabcyborg]

• Stop trying to run actions if the form is not an object after calling FrmForm::maybe_get_form.
• Simplifying the $child_entry declaration line. It has an isset && check that is now reduced to a ! empty. I also dropped the Is_object check, as it now happens earlier and this could would never be reached with an invalid form object.

[coderabbitai]

Walkthrough

The changes modify the trigger_actions method within the FrmFormActionsController class. An early return has been added to exit the method if the $form parameter is not an object. Additionally, the logic for detecting child entries has been simplified by directly checking if parent_form_id is numeric and not empty, streamlining the control flow.

Changes

File(s)	Change Summary
classes/controllers/FrmFormActionsController.php	Added an early return if $form is not an object; simplified child entry detection by directly verifying the numeric and non-empty parent_form_id.

Sequence Diagram(s)

sequenceDiagram
    participant C as Caller
    participant M as trigger_actions Method

    C->>M: Call trigger_actions($form, ...)
    alt $form is not an object
        M-->>C: Return early (no further processing)
    else $form is an object
        M->>M: Check if parent_form_id is numeric and non-empty
        alt Child entry condition met
            M->>M: Process as a child entry
        else
            M->>M: Proceed with standard logic
        end
        M-->>C: Continue execution with processed data
    end

Loading

Possibly related PRs

• Necessary code for repeater actions #1619: This PR includes updates to the trigger_actions method, particularly by adding a conditional block for custom form action triggers, which aligns closely with the modifications made in this change.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 842a6f3 and 7d0c38d.

📒 Files selected for processing (1)

• classes/controllers/FrmFormActionsController.php (2 hunks)

🧰 Additional context used

🧬 Code Definitions (1)

classes/controllers/FrmFormActionsController.php (1)

classes/models/FrmFormAction.php (1)

• form (93-97)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: PHP 8 tests in WP trunk
• GitHub Check: Run PHP Syntax inspection (8.3)
• GitHub Check: Cypress

🔇 Additional comments (2)

classes/controllers/FrmFormActionsController.php (2)

552-554: Good defensive programming practice added.

Adding an early return check ensures the method exits gracefully if $form is not an object after FrmForm::maybe_get_form is called. This prevents potential PHP errors in the subsequent code that expects $form to be an object and improves the overall reliability of the action execution process.

---

586-586: Nice simplification of the child entry detection logic.

The condition for detecting a child entry has been streamlined by directly checking if parent_form_id is numeric and not empty, eliminating the need for an isset && check that was previously used. This is possible because the code now has the early return check that ensures $form is always an object when this line executes.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.