Use kses echo

[Crabcyborg]

This update cleans things up. It allows us to remove a lot of the // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped comments.

Now the ones that are left aren't calling our kses function.

[coderabbitai]

Walkthrough

This pull request refactors various parts of the codebase to streamline how sanitized HTML content is output. In every instance where content was previously sanitized via FrmAppHelper::kses (or maybe_kses) and then echoed, the code now directly calls FrmAppHelper::kses_echo to handle both sanitization and immediate output. These changes affect helpers, models, views, controller methods, and even CSS output while keeping the parameters and overall control flow unchanged. No public API declarations have been modified.

Changes

Files	Change Summary
classes/helpers/FrmFieldsHelper.php, classes/models/FrmAddon.php, classes/models/fields/FrmFieldType.php	Replaced echo FrmAppHelper::kses(...) with FrmAppHelper::kses_echo(...) for field labels, license messages, and similar outputs.
classes/views/addons/addon.php, classes/views/form-templates/template.php, classes/views/frm-fields/back-end/field-choices.php, classes/views/frm-forms/add_field.php, classes/views/frm-forms/add_field_links.php, classes/views/frm-settings/form.php, classes/views/frm-settings/tabs.php, classes/views/inbox/banner.php, classes/views/shared/admin-cta.php, classes/views/shared/admin-header.php, classes/views/shared/errors.php, classes/views/shared/images-dropdown.php, classes/views/shared/toggle.php, classes/views/shared/upgrade_overlay.php, classes/views/solutions/_import.php, classes/widgets/FrmShowForm.php	Unified output methods by replacing manual echo of sanitized content with direct calls to FrmAppHelper::kses_echo(...) across various UI components and templates.
css/_single_theme.css.php	Updated CSS output for font-family styles by switching from echo FrmAppHelper::kses(...) to FrmAppHelper::kses_echo(...).
stripe/controllers/FrmTransLitePaymentsController.php, stripe/controllers/FrmTransLiteSubscriptionsController.php, stripe/helpers/FrmTransLiteAppHelper.php	Modified output of receipt and confirmation links, replacing echo-based sanitization with direct output via FrmAppHelper::kses_echo(...) in Stripe-related controllers and helpers.

Possibly related PRs

• New sales API #2205: The changes in the main PR and the retrieved PR are related as both involve modifications to the output methods in their respective classes, specifically transitioning from FrmAppHelper::kses to FrmAppHelper::kses_echo, indicating a focus on improving output handling in the code.
• Allow links in GDPR agreement text #2288: The changes in the main PR and the retrieved PR are related as both involve replacing the output method with FrmAppHelper::kses_echo, specifically focusing on how sanitized content is rendered in different contexts.
• QoL Release - Lite Version #2215: The changes in the main PR, which involve replacing FrmAppHelper::kses with FrmAppHelper::kses_echo for outputting sanitized content, are related to the changes in the retrieved PR, where similar modifications are made to the output methods in various classes. Both PRs focus on improving the output handling of sanitized content, indicating a direct connection at the code level.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c7c7cdc and beb13d1.

📒 Files selected for processing (1)

• classes/views/shared/errors.php (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• classes/views/shared/errors.php

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Cypress

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.