Skip to content

Update versions#2308

Merged
Crabcyborg merged 2 commits into
masterfrom
prepare_for_6.20
Apr 8, 2025
Merged

Update versions#2308
Crabcyborg merged 2 commits into
masterfrom
prepare_for_6.20

Conversation

@Crabcyborg
Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 8, 2025

Walkthrough

This pull request updates version information and PHP documentation annotations across multiple files. In several classes, @since and @deprecated tags are changed from placeholders (or from 6.19) to 6.20, and the plugin’s version number is incremented from 6.19 to 6.20. The updates also extend to the translation POT file with revised version, timestamp, and message identifiers.

Changes

File(s) Change Summary
classes/controllers/FrmFormActionsController.php, classes/controllers/FrmFormsController.php Updated method documentation: changed @since tags from x.x to 6.20 for methods (e.g. prevent_wpml_translations, maybe_block_preview, include_device_too_small_message).
classes/helpers/FrmAppHelper.php, classes/helpers/FrmFormsHelper.php, classes/helpers/FrmSerializedStringParserHelper.php, classes/helpers/FrmStylesHelper.php Updated helper classes’ docblocks: modified @since (and @deprecated) tags to 6.20 and bumped static version from '6.19' to '6.20'.
classes/models/FrmFormTemplateApi.php, classes/models/fields/FrmFieldGdpr.php Revised model methods’ documentation: updated deprecation notices and @since annotations from x.x to 6.20.
classes/views/form-templates/modals/code-from-email-modal.php, classes/views/shared/small-device-message.php Updated version annotations in deprecation calls and file headers from x.x to 6.20.
formidable.php, js/formidable.js Incremented the plugin version in formidable.php to 6.20 and updated the @since tag in the animateScroll function within formidable.js.
languages/formidable.pot Revised POT file: updated project version from 6.19 to 6.20, modified POT creation date, adjusted line number references, and added new message identifiers.

Possibly related PRs

  • Prepare for 6.17 #2218: Updates the @since tag for a different method in the same controller, showing a related approach to version documentation.

Suggested labels

run analysis, run tests

Suggested reviewers

  • truongwp

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f8f5e53 and fdbda13.

⛔ Files ignored due to path filters (1)
  • js/formidable.min.js is excluded by !**/*.min.js, !**/*.min.js
📒 Files selected for processing (13)
  • classes/controllers/FrmFormActionsController.php (1 hunks)
  • classes/controllers/FrmFormsController.php (2 hunks)
  • classes/helpers/FrmAppHelper.php (2 hunks)
  • classes/helpers/FrmFormsHelper.php (3 hunks)
  • classes/helpers/FrmSerializedStringParserHelper.php (2 hunks)
  • classes/helpers/FrmStylesHelper.php (2 hunks)
  • classes/models/FrmFormTemplateApi.php (2 hunks)
  • classes/models/fields/FrmFieldGdpr.php (2 hunks)
  • classes/views/form-templates/modals/code-from-email-modal.php (1 hunks)
  • classes/views/shared/small-device-message.php (1 hunks)
  • formidable.php (1 hunks)
  • js/formidable.js (1 hunks)
  • languages/formidable.pot (34 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: PHP 8 tests in WP trunk
  • GitHub Check: PHP 7.4 tests in WP trunk
  • GitHub Check: PHP 8 tests in WP trunk
  • GitHub Check: Cypress
  • GitHub Check: PHP 7.4 tests in WP trunk
  • GitHub Check: Cypress
  • GitHub Check: Spell Check with Typos
🔇 Additional comments (23)
classes/views/form-templates/modals/code-from-email-modal.php (1)

12-12: Version number correctly updated in deprecated file notice.

The version number has been updated from a placeholder to the specific version 6.20, providing clear documentation of when this file was deprecated.

classes/helpers/FrmStylesHelper.php (2)

456-456: Documentation updated with correct version number.

The @since annotation for css_key_is_valid has been properly updated from a placeholder value to version 6.20.


471-471: Documentation updated with correct version number.

The @since annotation for css_value_is_valid has been properly updated from a placeholder value to version 6.20.

classes/helpers/FrmSerializedStringParserHelper.php (2)

56-56: Documentation updated with correct version number.

The @since annotation for serialized_value_is_valid has been properly updated from a placeholder value to version 6.20.


66-66: Documentation updated with correct version number.

The @since annotation for serialized_string_is_invalid has been properly updated from a placeholder value to version 6.20.

formidable.php (1)

5-5: Plugin version number successfully updated.

The main plugin version has been incremented from 6.19 to 6.20, aligning with the documentation changes in other files. This version update ensures consistency across all components of the plugin.

js/formidable.js (1)

1662-1662: Documentation Update for animateScroll Function:
The @since tag for the animateScroll function has been updated to 6.20 to reflect the current version. There are no modifications to the underlying logic; this update solely ensures that documentation stays current.

classes/views/shared/small-device-message.php (1)

5-5: Version Annotation Update in PHP Header:
The documentation comment’s @since tag has been updated to 6.20 from the previous placeholder. This change is consistent with the version bump across the codebase.

classes/controllers/FrmFormActionsController.php (1)

672-679: Update @SInCE in prevent_wpml_translations():
The PHP docblock for the prevent_wpml_translations method has been updated with an @since 6.20 tag. This documentation update correctly reflects that the method’s versioning information has been updated, while no functional changes were made.

classes/helpers/FrmAppHelper.php (1)

32-32: Plugin Version Bump:
The static variable $plug_version has been updated from '6.19' to '6.20'. This change ensures that the plugin version reference is consistent throughout the codebase and is in line with the PR’s version update objective.

classes/helpers/FrmFormsHelper.php (2)

1846-1863: Version tag updated appropriately.

The @since tag has been updated from a placeholder to the specific version 6.20, correctly documenting when this method was introduced.


1891-1898: Deprecation updated correctly.

The @deprecated tag has been properly updated from a placeholder to version 6.20, providing clarity on when this method was officially deprecated.

classes/models/fields/FrmFieldGdpr.php (2)

162-163: Version tag updated properly.

The @since tag for the validate method has been correctly updated to version 6.20.


185-186: Version tag updated properly.

The @since tag for the force_required_field method has been correctly updated to version 6.20.

classes/controllers/FrmFormsController.php (2)

686-687: Version tag updated properly.

The @since tag for the maybe_block_preview method has been correctly updated to version 6.20.


1927-1928: Version tag updated properly.

The @since tag for the include_device_too_small_message method has been correctly updated to version 6.20.

classes/models/FrmFormTemplateApi.php (3)

68-70: Deprecation notice updated correctly.

The deprecated method notice has been updated to use version 6.20 instead of a placeholder, providing clarity on when this method was officially deprecated.


75-78: Deprecation notice updated correctly.

The deprecated method notice has been updated to use version 6.20 instead of a placeholder, providing clarity on when this method was officially deprecated.


87-90: Deprecation notice updated correctly.

The deprecated method notice has been updated to use version 6.20 instead of a placeholder, providing clarity on when this method was officially deprecated.

languages/formidable.pot (4)

5-5: Version update looks good.

The plugin version has been correctly updated from 6.19 to 6.20 in the POT file, which matches the PR objective of updating versions.


12-12: POT creation date updated properly.

The timestamp has been updated to April 8, 2025, which aligns with the version update.


781-797: Good addition of form validation error messages.

These new error messages enhance user experience by providing clearer feedback for form key validation issues and permission errors:

  • "Form key is invalid"
  • "Form key is missing"
  • "Form does not exist"
  • "You do not have permission to view this form"

These messages will help users better understand what went wrong when accessing forms.


127-127: Reference line number updates look good.

These changes update file path references and line numbers to maintain correct mappings between translatable strings and their source code locations after code modifications.

Also applies to: 296-296, 484-489, 501-502

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Crabcyborg Crabcyborg merged commit f92eb79 into master Apr 8, 2025
32 of 34 checks passed
@Crabcyborg Crabcyborg deleted the prepare_for_6.20 branch April 8, 2025 15:50
@coderabbitai coderabbitai Bot mentioned this pull request Oct 14, 2025
@coderabbitai coderabbitai Bot mentioned this pull request Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant