Fix new pill styling on payment field#2322
Conversation
WalkthroughThe change updates a CSS selector in the stylesheet to refine which elements receive specific styling. The selector previously targeted all span elements within list items under the Changes
Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
css/frm_admin.css (1)
7826-7833: Add contextual comment for future maintainers
It may be helpful to include an inline CSS comment explaining why.frm-new-pillis excluded here. A brief note will clarify the intention for anyone revisiting this rule.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
css/frm_admin.css(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: PHP 8 tests in WP trunk
- GitHub Check: PHP 7.4 tests in WP trunk
- GitHub Check: Cypress
- GitHub Check: Run PHP Syntax inspection (8.3)
- GitHub Check: Run PHP Syntax inspection (8.3)
- GitHub Check: PHP 8 tests in WP trunk
- GitHub Check: PHP 7.4 tests in WP trunk
- GitHub Check: Cypress
🔇 Additional comments (1)
css/frm_admin.css (1)
7826-7833: Correctly exclude new pills from ellipsis styling
The updated selector#frm-insert-fields li span:not(.frm-new-pill)properly prevents.frm-new-pillspans from receiving the overflow and width rules, ensuring new pill elements render at their intrinsic size rather than being forced to 100% width. This aligns perfectly with the PR objective.
This update just prevents this from being 100% width.