Skip to content

Fix new pill styling on payment field#2322

Merged
Crabcyborg merged 1 commit into
masterfrom
fix_new_pill_styling_on_payment_field
Apr 23, 2025
Merged

Fix new pill styling on payment field#2322
Crabcyborg merged 1 commit into
masterfrom
fix_new_pill_styling_on_payment_field

Conversation

@Crabcyborg
Copy link
Copy Markdown
Contributor

This update just prevents this from being 100% width.

Advanced Fields

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2025

Walkthrough

The change updates a CSS selector in the stylesheet to refine which elements receive specific styling. The selector previously targeted all span elements within list items under the #frm-insert-fields element. The update now excludes spans with the .frm-new-pill class from these styles by using the :not(.frm-new-pill) pseudo-class. No changes were made to any exported or public entities.

Changes

File(s) Change Summary
css/frm_admin.css Modified CSS selector to exclude .frm-new-pill spans from certain styles under #frm-insert-fields.

Possibly related PRs


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
css/frm_admin.css (1)

7826-7833: Add contextual comment for future maintainers
It may be helpful to include an inline CSS comment explaining why .frm-new-pill is excluded here. A brief note will clarify the intention for anyone revisiting this rule.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dd3d904 and 25c58e6.

📒 Files selected for processing (1)
  • css/frm_admin.css (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: PHP 8 tests in WP trunk
  • GitHub Check: PHP 7.4 tests in WP trunk
  • GitHub Check: Cypress
  • GitHub Check: Run PHP Syntax inspection (8.3)
  • GitHub Check: Run PHP Syntax inspection (8.3)
  • GitHub Check: PHP 8 tests in WP trunk
  • GitHub Check: PHP 7.4 tests in WP trunk
  • GitHub Check: Cypress
🔇 Additional comments (1)
css/frm_admin.css (1)

7826-7833: Correctly exclude new pills from ellipsis styling
The updated selector #frm-insert-fields li span:not(.frm-new-pill) properly prevents .frm-new-pill spans from receiving the overflow and width rules, ensuring new pill elements render at their intrinsic size rather than being forced to 100% width. This aligns perfectly with the PR objective.

@Crabcyborg Crabcyborg merged commit 8627ed3 into master Apr 23, 2025
32 of 34 checks passed
@Crabcyborg Crabcyborg deleted the fix_new_pill_styling_on_payment_field branch April 23, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant