Add down states to sales api banners

[Crabcyborg]

I'm also nesting the SCSS now.

[coderabbitai]

Walkthrough

The changes refactor the SCSS styling for the #frm_sale_banner component by consolidating multiple separate CSS selectors into a single, nested SCSS block. This restructuring organizes the rules for child elements, anchor tags, and hover states under the main banner selector, while preserving the original styling and effects. No exported or public code entities are altered, as the modifications are limited to style rule organization.

Changes

File(s)	Change Summary
resources/scss/admin/components/sales/banner.scss	Refactored all CSS rules for #frm_sale_banner into a single nested SCSS block, consolidating selectors and hover states, with no changes to actual styling effects.

Possibly related PRs

• Sales API Phase 2 #2318: Introduces backend logic and frontend integration for displaying and dismissing the sales banner, modifying the same banner styling files and relating directly to the same UI component's appearance and behavior.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 4

🧹 Nitpick comments (2)

resources/scss/admin/components/sales/banner.scss (2)

47-53: Scope the dismiss button more precisely.

The selector .dismiss may collide with other elements. Scope it to an anchor or adopt a BEM-style class name:

-.dismiss {
+.frm-sale-banner__dismiss-button {  // or: a.dismiss

This change improves specificity and prevents unintended matches.

---

55-61: Add keyboard focus styling alongside hover.

You’ve added a hover state filter—excellent. For accessibility, extend this to keyboard users by including :focus-visible:

&:hover,
&:focus-visible {
  filter: brightness(90%);
  a:not(.dismiss) {
    filter: brightness(90%);
  }
}

This ensures consistent feedback for pointer and keyboard interactions.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 75e06ff and b0375e6.

📒 Files selected for processing (1)

• resources/scss/admin/components/sales/banner.scss (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: PHP 8 tests in WP trunk
• GitHub Check: Run PHP Syntax inspection (8.3)
• GitHub Check: PHP 8 tests in WP trunk
• GitHub Check: PHP 7.4 tests in WP trunk
• GitHub Check: Cypress
• GitHub Check: PHP 7.4 tests in WP trunk
• GitHub Check: Cypress