Skip to content

Make unread inbox count checks more consistent #2354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Crabcyborg wants to merge 1 commit into from
Closed

Make unread inbox count checks more consistent #2354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion classes/helpers/FrmEntriesHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -879,7 +879,7 @@ public static function get_visible_unread_inbox_count() {
}

$inbox = new FrmInbox();
$inbox_count = count( $inbox->unread() );
$inbox_count = $inbox->get_unread_count();

if ( ! $inbox_count ) {
return 0;
Expand Down
13 changes: 12 additions & 1 deletion classes/models/FrmInbox.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ public function unread() {
* @return string
*/
public function unread_html( $filtered = true ) {
$count = count( $this->unread() );
$count = $this->get_unread_count();
if ( ! $count ) {
return '';
}
Expand All @@ -334,6 +334,17 @@ public function unread_html( $filtered = true ) {
return (string) apply_filters( 'frm_inbox_badge', $html );
}

/**
* Get unread inbox count.
*
* @since x.x
*
* @return int
*/
public function get_unread_count() {
return count( $this->unread() );
}

/**
* @since 4.05.02
*
Expand Down
Loading