Fix pro issue 5819 / focus first input in option container with error

[Crabcyborg]

Fixes https://github.com/Strategy11/formidable-pro/issues/5819

Pre-release
formidable-6.21.2b.zip

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.62%. Comparing base (0e00851) to head (72bd7d1).
Report is 62 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #2375      +/-   ##
============================================
+ Coverage     27.58%   27.62%   +0.04%     
- Complexity     8647     8663      +16     
============================================
  Files           140      140              
  Lines         28555    28596      +41     
============================================
+ Hits           7876     7901      +25     
- Misses        20679    20695      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[coderabbitai]

Walkthrough

A new conditional branch is introduced in the checkForErrorsAndMaybeSetFocus function within js/formidable.js. This branch targets elements with the frm_opt_container class, focusing the first input inside such containers when an error is detected, supplementing the existing focus logic for other element types.

Changes

File(s)	Change Summary
js/formidable.js	Added logic in checkForErrorsAndMaybeSetFocus to focus the first input in .frm_opt_container elements when errors are present.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Form
    participant ErrorHandler

    User->>Form: Submit form
    Form->>ErrorHandler: checkForErrorsAndMaybeSetFocus()
    ErrorHandler->>Form: Iterate through error elements
    alt Element is .frm_opt_container
        ErrorHandler->>Form: Find first input in container
        ErrorHandler->>Form: Call focusInput on input
    else Other element types
        ErrorHandler->>Form: Existing focus logic
    end

Loading

Possibly related PRs

• Strategy11/formidable-forms#2122: Introduced the focusInput function now leveraged in the new .frm_opt_container focus logic, indicating a direct enhancement of the prior focus management implementation.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aead135 and 72bd7d1.

📒 Files selected for processing (1)

• js/formidable.js (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: PHP 7.4 tests in WP trunk
• GitHub Check: PHP 8 tests in WP trunk
• GitHub Check: Cypress
• GitHub Check: Cypress
• GitHub Check: Cypress
• GitHub Check: PHP 8 tests in WP trunk
• GitHub Check: PHP 7.4 tests in WP trunk
• GitHub Check: PHP 8 tests in WP trunk
• GitHub Check: PHP 7.4 tests in WP trunk

🔇 Additional comments (1)

js/formidable.js (1)

1382-1388: LGTM! Clean implementation that follows existing patterns.

The new conditional branch correctly handles option containers by:

• Following the established pattern used for other element types
• Using appropriate DOM methods to find the first input
• Properly calling focusInput() and breaking the loop
• Addressing the PR objective to improve focus behavior on errors

Note that the selector 'input' specifically targets input elements rather than all form controls ('input, select, textarea'). This appears intentional for option containers, which typically contain radio buttons or checkboxes.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.