Autocomplete does not init for files dropdown for new action#2395
Merged
Crabcyborg merged 3 commits intoJun 19, 2025
Merged
Conversation
Contributor
WalkthroughThe changes update the initialization of selection autocomplete functionality within Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant AdminJS
participant frmDomAutocomplete
User->>AdminJS: Triggers action (e.g., load, duplicate, add)
AdminJS->>AdminJS: Calls initAutocomplete(container)
AdminJS->>frmDomAutocomplete: Calls initSelectionAutocomplete(container)
frmDomAutocomplete-->>AdminJS: Initializes autocomplete in container
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (8)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
js/formidable_admin.js (3)
7133-7136: Normalise the argument type
newActionis a raw DOM element, whereas other call-sites pass a jQuery object. Keep the contract consistent and shield the downstream API from mixed types.- initSelectionAutocomplete( newAction ); + initSelectionAutocomplete( jQuery( newAction ) );
7232-7234: Same normalisation applies hereFor consistency and safety, wrap
newActionin jQuery before forwarding.- initSelectionAutocomplete( newAction ); + initSelectionAutocomplete( jQuery( newAction ) );
9206-9208: Make the wrapper tolerant to input variationsAccept either a DOM node, jQuery object, or no argument at all to remain backward-compatible and avoid type issues.
-function initSelectionAutocomplete( container ) { - frmDom.autocomplete.initSelectionAutocomplete( container ); +function initSelectionAutocomplete( container ) { + const $container = container ? jQuery( container ) : undefined; + frmDom.autocomplete.initSelectionAutocomplete( $container ); }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
js/formidable_admin.js(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (19)
- GitHub Check: Run PHP Syntax inspection (8.3)
- GitHub Check: Run PHPCS inspection
- GitHub Check: PHP 7.4 tests in WP trunk
- GitHub Check: PHP 8 tests in WP trunk
- GitHub Check: Cypress
- GitHub Check: Run Rector inspection
- GitHub Check: Run PHP Syntax inspection (8.3)
- GitHub Check: Run PHPCS inspection
- GitHub Check: PHP 7.4 tests in WP trunk
- GitHub Check: Run ESLint
- GitHub Check: PHP 8 tests in WP trunk
- GitHub Check: Run Rector inspection
- GitHub Check: PHP 7.4 tests in WP trunk
- GitHub Check: PHP 8 tests in WP trunk
- GitHub Check: Run PHPCS inspection
- GitHub Check: Psalm
- GitHub Check: Cypress
- GitHub Check: Cypress
- GitHub Check: Run PHP Syntax inspection (8.3)
🔇 Additional comments (1)
js/formidable_admin.js (1)
654-654: Let’s correct the regex and search again for zero-arg calls:#!/bin/bash # Find invocations of initSelectionAutocomplete() with no arguments rg -n 'initSelectionAutocomplete\s*\(\s*\)' --glob '*.js'
truongwp
approved these changes
Jun 19, 2025
Contributor
truongwp
left a comment
truongwp
left a comment
There was a problem hiding this comment.
This looks good. Thanks @Crabcyborg!
Crabcyborg
changed the title
Contributor
Author
|
Thanks @truongwp! 🚀 |
Crabcyborg
deleted the
fix_autocomplete_does_not_init_for_files_dropdown_for_new_action
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was working on a Google Sheets release, but noticed that the autocomplete dropdown was always empty for a new form action.
This update fixes it, and makes some of the calls more consistent.
I added a temporary workaround in the Google Sheets code as well so I could still get a release out https://github.com/Strategy11/formidable-googlespreadsheet/pull/66