Fix name field in minimized HTML

[truongwp]

Fixes https://github.com/Strategy11/formidable-pro/issues/5870

[coderabbitai]

Walkthrough

The code for rendering the default input field in the combo field was refactored to use an attributes array for building HTML attributes, replacing the previous approach of echoing each attribute inline. The array is converted to HTML parameters before outputting the input element.

Changes

File(s)	Change Summary
classes/views/frm-fields/front-end/combo-field/...	Refactored input rendering to use an attributes array and helper function for HTML attribute output.

Suggested labels

run analysis, run tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 PHPStan (2.1.15)

Note: Using configuration file /phpstan.neon.
Invalid configuration:
Unexpected item 'parameters › strictRules'.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0cae9a and 7d50912.

📒 Files selected for processing (1)

• classes/views/frm-fields/front-end/combo-field/combo-field.php (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

classes/views/frm-fields/front-end/combo-field/combo-field.php (2)

classes/helpers/FrmAppHelper.php (2)

• FrmAppHelper (6-4600)
• array_to_html_params (1366-1375)

classes/models/fields/FrmFieldCombo.php (1)

• print_input_atts (371-411)

🔇 Additional comments (3)

classes/views/frm-fields/front-end/combo-field/combo-field.php (3)

60-64: LGTM: Clean attributes array initialization.

The refactoring to use an attributes array is a good improvement. The initial array structure with type, id, and value is clear and maintainable.

---

66-72: LGTM: Conditional attributes logic preserved correctly.

The conditional addition of data-frmval and name attributes maintains the same logic as before but in a more structured way. The conditions are appropriate:

• data-frmval is only added when there's a field value
• name is only added when remove_names is not set (which relates to the PR objective of fixing the name field in minimized HTML)

---

73-76: LGTM: Consistent output generation with proper escaping.

The refactored output approach using FrmAppHelper::array_to_html_params() is excellent because:

• It provides consistent attribute handling across the framework
• Ensures proper escaping of attribute names and values
• Maintains clean separation between attribute building and output generation
• Likely addresses the minimized HTML issue mentioned in the PR objectives

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Crabcyborg]

I haven't tested this yet but this looks good to me.

Thanks Truong!

🚀