Skip to content

Make css valid check more type safe #2441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 1 commit into from
Jul 28, 2025
Merged

Make css valid check more type safe #2441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion classes/helpers/FrmStylesHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,10 +470,18 @@ private static function css_key_is_valid( $key ) {
*
* @since 6.20
*
* @param string $var
* @param mixed $var
* @return bool
*/
private static function css_value_is_valid( $var ) {
if ( is_numeric( $var ) ) {
return true;
}

if ( ! is_string( $var ) ) {
return false;
}

// None of these substrings should be present in any CSS value.
$invalid_substrings = array(
'function(',
Expand Down
Loading