Skip to content

show css vars for fields values that are changed later via css_var_prepare_value #2456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Liviu-p wants to merge 1 commit into from
Closed

show css vars for fields values that are changed later via css_var_prepare_value #2456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion classes/helpers/FrmStylesHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,10 @@ public static function output_vars( $settings, $defaults = array(), $vars = arra
if ( ! isset( $defaults[ $var ] ) ) {
$defaults[ $var ] = '';
}
$show = empty( $defaults ) || ( $settings[ $var ] !== '' && $settings[ $var ] !== $defaults[ $var ] );

// These fields value may be changed later in css_var_prepare_value() as $settings[ $var ] will be the same as $defaults[ $var ] and the condition will be false
$show_fields = array( 'field_border_width', 'border_radius', 'border_width_error', 'box_shadow', 'font' );
$show = empty( $defaults ) || ( $settings[ $var ] !== '' && $settings[ $var ] !== $defaults[ $var ] ) || in_array( $var, $show_fields, true );
if ( $show && self::css_value_is_valid( $settings[ $var ] ) ) {
Comment thread
Liviu-p marked this conversation as resolved.
echo '--' . esc_html( self::clean_var_name( str_replace( '_', '-', $var ) ) ) . ':' . self::css_var_prepare_value( $settings, $var ) . ';'; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
}
Expand Down
Loading