Fix CAPTCHA validation issue when using Square

[Crabcyborg]

Fixes https://github.com/Strategy11/formidable-pro/issues/5940

The field validation is happening incorrectly during the buyer verification. Captcha validation fails because it was already validated.

This update removes some of the keys getting sent in the form data to avoid this.

Pre-release
formidable-6.23b.zip

[coderabbitai]

Walkthrough

This change updates JavaScript logic related to form submission and payment processing. It modifies the argument passed to submitFormNow in js/formidable.js, and in square/js/frontend.js, it removes some fields from FormData before AJAX submission and eliminates a call to event.preventDefault() in a payment handler.

Changes

Cohort / File(s)	Change Summary
Form Submission Argument Update js/formidable.js	The submitFormManual method now calls submitFormNow with only the form object, removing the classList argument. No other logic is changed.
Square Payment Form Adjustments square/js/frontend.js	In verifyBuyer, three fields are deleted from FormData before AJAX. In handlePaymentMethodSubmission, the call to event.preventDefault() is removed. No other logic is altered.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

• Fix pro issue 1961 #2003: Refactors submitFormManual and related reCAPTCHA validation in js/formidable.js, overlapping with this PR's changes to form submission handling and argument passing.

Note

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 02d6462 and 86565e9.

📒 Files selected for processing (2)

• js/formidable.js (1 hunks)
• square/js/frontend.js (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

• GitHub Check: PHP 7.4 tests in WP trunk
• GitHub Check: PHP 8 tests in WP trunk
• GitHub Check: Run PHP Syntax inspection (8.3)
• GitHub Check: Cypress
• GitHub Check: Cypress
• GitHub Check: PHP 7.4 tests in WP trunk
• GitHub Check: PHP 8 tests in WP trunk

🔇 Additional comments (2)

square/js/frontend.js (1)

139-144: Prevent unnecessary form validation in verifyBuyer by stripping form control params

Confirmed that the FrmSquareLiteAppController::verify_buyer handler only cares about the action and nonce fields—and does not reference frm_action, form_key, or item_key. Removing those prevents the full Formidable validation (and CAPTCHA) from kicking in during buyer verification without breaking the AJAX endpoint.

Optional hardening (nice-to-have):

 // Also remove any captcha response values to avoid custom hooks from triggering.
 formData.delete( 'g-recaptcha-response' );
 formData.delete( 'h-captcha-response' );
 formData.delete( 'cf-turnstile-response' );

js/formidable.js (1)

1809-1809: All submitFormNow invocations use a single argument

I’ve verified every call to submitFormNow in js/formidable.js (lines 1758, 1763, 1809) now passes only the form element, matching the one-arg signature. There are no remaining two-argument calls—LGTM.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch pro_issue_5940

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.