Fix all ESLint errors across JavaScript codebase#2470
Merged
Conversation
- Add 'run analysis' label condition to jscs.yml workflow - Follow same pattern as other workflows (cypress, phpunit, qadeploy) - ESLint now runs on push to master or when PR has 'run analysis' label - Enables manual control of when ESLint analysis runs on PRs
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/admin-js-webpack-refactor #2470 +/- ##
====================================================================
Coverage ? 27.34%
Complexity ? 8708
====================================================================
Files ? 140
Lines ? 28743
Branches ? 0
====================================================================
Hits ? 7860
Misses ? 20883
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@Crabcyborg, I also found some ways to prevent installing packages with every PR by caching them, which will help actions run faster. I’ll work on this when I have some free time, just wanted to let you know. |
Crabcyborg
reviewed
Aug 25, 2025
Crabcyborg
approved these changes
Aug 25, 2025
Contributor
Crabcyborg
left a comment
Crabcyborg
left a comment
There was a problem hiding this comment.
Thanks @shervElmi!
I think these changes all looks good. I haven't tried testing yet though.
Crabcyborg
merged commit 280828c
into
feature/admin-js-webpack-refactor
11 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves all remaining ESLint errors in our JavaScript files, bringing the codebase into full compliance with our linting standards.
Note
All functionality remains unchanged, and this is purely a code quality improvement that brings us into full ESLint compliance.
Base PR
#2464