Skip to content

Update readme for v6.25.1#2574

Merged
Crabcyborg merged 5 commits into
masterfrom
update_readme_6.25.1
Nov 4, 2025
Merged

Update readme for v6.25.1#2574
Crabcyborg merged 5 commits into
masterfrom
update_readme_6.25.1

Conversation

@Crabcyborg
Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 4, 2025

Walkthrough

Adds a 6.25.1 release: bump plugin version and FrmAppHelper::$plug_version, inserts a 6.25.1 changelog/readme block, appends a large denylist expansion, and updates many @since PHPDoc/JSDoc annotations. No functional code changes.

Changes

Cohort / File(s) Change Summary
Release notes & readme
changelog.txt, readme.txt
Added a 6.25.1 changelog block with new items and fixes; bumped Stable tag from 6.256.25.1 and removed older 6.23 block.
Plugin header & version constant
formidable.php, classes/helpers/FrmAppHelper.php
Updated plugin header Version to 6.25.1 and changed FrmAppHelper::$plug_version from '6.25''6.25.1'.
Denylist expansion
denylist/splorp-wp-comment.txt
Large additive update: appended hundreds/thousands of URL patterns, keywords and phrases across multiple languages (spam/blacklist patterns). No code changes.
@SInCE PHPDoc/JSDoc updates
classes/controllers/..., classes/helpers/..., classes/models/..., classes/views/welcome-tour/..., js/formidable.js
Replaced placeholder @since x.x with @since 6.25.1 across many controllers, helpers, models, and view files; updated one public property docblock; updated a JSDoc @since tag. No functional or signature changes.
Minor doc-only updates
classes/views/welcome-tour/*.php, classes/controllers/*
Multiple file header docblock @since annotations updated to 6.25.1. No behavior changes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Heterogeneous changes: many trivial doc updates plus a very large denylist data addition that needs spot-checking.
  • Areas to review closely:
    • denylist/splorp-wp-comment.txt — ensure entries are intentional, correctly formatted, and scoped appropriately.
    • changelog.txt / readme.txt — verify formatting and new entries match release policy.
    • formidable.php and classes/helpers/FrmAppHelper.php — confirm version strings are consistent.
    • Any public property docblock updates (e.g., installed_after_welcome_tour_update) for accuracy.

Possibly related PRs

Suggested reviewers

  • lauramekaj1

Pre-merge checks and finishing touches

❌ Failed checks (2 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Update readme for v6.25.1' is partially related to the changeset. While readme.txt is updated, the PR actually includes comprehensive version bump changes across 20+ files (docblock updates, version bump in formidable.php, changelog updates, and denylist expansions), making the title overly narrow and not representative of the main scope. Consider a more comprehensive title like 'Release v6.25.1 with documentation and version updates' or clarify if the primary objective is really just the readme update.
Description check ❓ Inconclusive No pull request description was provided by the author. While a description is not strictly required, the lack of any explanation about the v6.25.1 release changes makes it difficult to understand the context and scope of this version bump release. Add a description explaining the v6.25.1 release scope, highlighting key changes like bug fixes, new features, version bumps, and documentation updates included in this release.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update_readme_6.25.1

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db8d546 and cc2429b.

📒 Files selected for processing (1)
  • denylist/splorp-wp-comment.txt (153 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Cypress
  • GitHub Check: PHP 7.4 tests in WP trunk
  • GitHub Check: PHP 8 tests in WP trunk
🔇 Additional comments (1)
denylist/splorp-wp-comment.txt (1)

1-62971: Verify denylist integrity and performance impact.

This PR adds 153 hunks (~thousands of entries) to an already extensive denylist file. The expansion is consistent with the 6.25.1 release goals and entries appear properly formatted and alphabetically organized across multiple languages.

However, with this significant growth, consider:

  1. Duplicate detection: Verify no duplicate entries exist within the new additions or overlap with existing patterns.
  2. Performance: Confirm the filtering logic downstream can efficiently handle the expanded denylist size without introducing lookup latency regressions.
  3. Long-term maintainability: The file is now very large. Consider whether a structured format (JSON/CSV with categories) or splitting into smaller indexed files would improve maintainability.

Run the following script to detect duplicates:

The data structure and format are solid. Assuming duplicate verification passes and no performance regression is observed in testing, this expansion is reasonable for the 6.25.1 release.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 943ef73 and 632fb94.

📒 Files selected for processing (2)
  • changelog.txt (1 hunks)
  • readme.txt (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: PHP 7.4 tests in WP trunk
  • GitHub Check: PHP 8 tests in WP trunk
  • GitHub Check: PHP 8 tests in WP trunk
  • GitHub Check: PHP 7.4 tests in WP trunk
  • GitHub Check: Cypress
  • GitHub Check: Cypress
  • GitHub Check: Run PHP Syntax inspection (8.3)
🔇 Additional comments (2)
changelog.txt (1)

2-13: Changelog 6.25.1 entry looks solid and consistent with readme.

No blocking issues found. Spelling, product names, and tone match prior entries.

readme.txt (1)

375-386: Changelog blocks verified as identical between readme.txt and changelog.txt.

The 6.25.1 release notes in both files match perfectly—no drift detected. The code is correct as-is.

Comment thread readme.txt
@Crabcyborg Crabcyborg merged commit 039ccc2 into master Nov 4, 2025
16 checks passed
@Crabcyborg Crabcyborg deleted the update_readme_6.25.1 branch November 4, 2025 17:12
stephywells pushed a commit that referenced this pull request Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant