Fix undefined array key warning in maybe_add_utm_license

[shervElmi]

Fixes an undefined array key warning when utm_medium is not present in the query args.

Demo

[coderabbitai]

Walkthrough

A guard condition is added to the maybe_add_utm_license method in the FrmAppHelper class to verify that utm_medium exists before comparing it to 'pro', preventing utm_license from being set when utm_medium is not provided.

Changes

Cohort / File(s)	Summary
Defensive guard addition classes/helpers/FrmAppHelper.php	Adds isset($query_args['utm_medium']) check before accessing and comparing utm_medium value in maybe_add_utm_license method

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–10 minutes

• The change is a straightforward guard clause that prevents potential undefined index access
• Single file affected with minimal scope
• Low risk defensive programming practice

Suggested labels

action: needs qa

Suggested reviewers

• Crabcyborg

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding a guard to prevent an undefined array key warning in the maybe_add_utm_license method.
Description check	✅ Passed	The description is directly related to the changeset, explaining that it fixes an undefined array key warning when utm_medium is not present, with supporting demo screenshots.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/utm-license-undefined-key

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 006d247 and e528882.

📒 Files selected for processing (1)

• classes/helpers/FrmAppHelper.php (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)

• GitHub Check: PHP 7.4 tests in WP trunk
• GitHub Check: PHP 8 tests in WP trunk
• GitHub Check: Cypress
• GitHub Check: Cypress
• GitHub Check: PHP 7.4 tests in WP trunk
• GitHub Check: PHP 8 tests in WP trunk
• GitHub Check: PHP 7.4 tests in WP trunk
• GitHub Check: Cypress
• GitHub Check: PHP 8 tests in WP trunk

🔇 Additional comments (1)

classes/helpers/FrmAppHelper.php (1)

176-176: LGTM! Correct fix for undefined array key warning.

The isset() check properly prevents an undefined array key warning when maybe_add_utm_license() is called from maybe_add_missing_utm() (line 235), where utm_medium may not exist in $query_args if it's already present in the URL. The guard condition is correctly placed first in the logic chain and follows PHP best practices.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions:
   | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context.
   Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Crabcyborg]

@shervElmi This doesn't look super ideal.

If this wasn't set, it must mean that the link already has a utm_medium. Ideally we would still check for that and still add a license, rather than do nothing.

[Crabcyborg]

Since this issue is causing our unit tests to fail, I went ahead and made a new PR #2606

Closing this one.