Add Address field part shortcodes to calculation popup#2639
Merged
Crabcyborg merged 4 commits intoDec 9, 2025
Merged
Conversation
- Added maybeAddAddressPartShortcodes function to support Address field part shortcodes (line1, line2, city, state, zip, country) - Added function call in field population loop to display Address field parts in calculation popup - Similar pattern to Name field implementation Resolves #5825
- Use template literals instead of string concatenation - Extract addressParts as const variable for better readability - Add descriptive JSDoc parameter documentation - Refine function description to be more professional and direct - Cleaner forEach syntax with consistent formatting
…hortcodes - Remove hyphens from JSDoc parameter descriptions for consistency with project style - Align parameter documentation format with standard JSDoc conventions
Crabcyborg
reviewed
Dec 8, 2025
- Added wp.hooks.doAction('frm_add_calc_field_shortcodes') hook
- Removed maybeAddAddressPartShortcodes() function (Address fields are Pro-only)
- Allows Pro and other extensions to add custom field part shortcodes
- Well-documented hook with JSDoc for extension developers
Crabcyborg
merged commit 6b72e5c
into
work_on_adding_show_options_to_code_list_popup
12 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base PR
#1379
Pro PR
https://github.com/Strategy11/formidable-pro/pull/6135
Fixes https://github.com/Strategy11/formidable-pro/issues/5825
Adds support for accessing individual Address field parts in calculations, similar to existing Name field functionality.