Skip to content

Prepare for 6.26#2643

Merged
Crabcyborg merged 2 commits into
masterfrom
prepare_for_6.26
Dec 9, 2025
Merged

Prepare for 6.26#2643
Crabcyborg merged 2 commits into
masterfrom
prepare_for_6.26

Conversation

@Crabcyborg
Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Dec 9, 2025

Walkthrough

This PR performs a version bump release from 6.25.1 to 6.26, updating the plugin version constant in two main files and converting @since documentation annotations from placeholder values (x.x) to the concrete version 6.26 across multiple controller, field model, and JavaScript files.

Changes

Cohort / File(s) Change Summary
Core Version Updates
formidable.php, classes/helpers/FrmAppHelper.php
Updated plugin version constant from 6.25.1 to 6.26; updated related @since annotations in docblocks from x.x to 6.26.
Controller Documentation Updates
classes/controllers/FrmAppController.php, classes/controllers/FrmFormsController.php, classes/controllers/FrmSimpleBlocksController.php, square/controllers/FrmSquareLiteActionsController.php
Updated @since annotations from x.x to 6.26 in method docblocks across controller classes.
Field Model Documentation Updates
classes/models/fields/FrmFieldCombo.php, classes/models/fields/FrmFieldName.php, classes/models/fields/FrmFieldType.php
Updated @since annotations from x.x to 6.26 in field model method docblocks.
Frontend Documentation Updates
js/src/admin/admin.js
Updated @since annotation from x.x to 6.26 in JSDoc for admin JavaScript function.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

This is a straightforward, repetitive version bump with consistent documentation updates across files. The single functional change—the version constant update—is minimal and non-complex.

Possibly related PRs

  • Prepare for v6.23 #2461: Performs similar release prep, updating FrmAppHelper::$plug\_version and converting @since docblocks to a concrete version (6.23).
  • Prepare for 6.21 #2358: Updates version metadata and modifies FrmAppHelper::$plug\_version in the same way.
  • Prepare for 6.25 #2540: Updates release/version metadata including FrmAppHelper::$plug\_version with comparable patterns.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, which is a significant omission for a version preparation commit affecting multiple files. Add a pull request description explaining the purpose of the version bump, scope of changes, and any testing performed to validate the version update across all affected files.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Prepare for 6.26' accurately describes the main objective: updating version numbers and documentation annotations from placeholder 'x.x' to version 6.26 across multiple files.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch prepare_for_6.26

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9b816e9 and dd37d7b.

⛔ Files ignored due to path filters (1)
  • js/formidable.min.js is excluded by !**/*.min.js, !**/*.min.js
📒 Files selected for processing (10)
  • classes/controllers/FrmAppController.php (2 hunks)
  • classes/controllers/FrmFormsController.php (1 hunks)
  • classes/controllers/FrmSimpleBlocksController.php (1 hunks)
  • classes/helpers/FrmAppHelper.php (4 hunks)
  • classes/models/fields/FrmFieldCombo.php (1 hunks)
  • classes/models/fields/FrmFieldName.php (2 hunks)
  • classes/models/fields/FrmFieldType.php (1 hunks)
  • formidable.php (1 hunks)
  • js/src/admin/admin.js (1 hunks)
  • square/controllers/FrmSquareLiteActionsController.php (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: PHP 8 tests in WP trunk
  • GitHub Check: Cypress
  • GitHub Check: PHP 7.4 tests in WP trunk
  • GitHub Check: Cypress
  • GitHub Check: PHP 8 tests in WP trunk
  • GitHub Check: PHP 7.4 tests in WP trunk
🔇 Additional comments (13)
square/controllers/FrmSquareLiteActionsController.php (1)

627-633: LGTM! Documentation updated correctly.

The @SInCE tag has been properly updated to reflect the 6.26 release version.

js/src/admin/admin.js (1)

463-471: Doc-only change looks good

loadTooltip JSDoc @SInCE updated to 6.26; no functional diff. Approved.

classes/controllers/FrmSimpleBlocksController.php (1)

76-76: LGTM!

The @since 6.26 annotation is correctly placed for the block_assets() method.

classes/models/fields/FrmFieldName.php (2)

310-310: LGTM!

The @since 6.26 annotation is correctly placed for the track_first_name_field() method.


328-328: LGTM!

The @since 6.26 annotation is correctly placed for the get_sub_field_input_attrs() method.

classes/models/fields/FrmFieldCombo.php (1)

520-520: LGTM!

The @since 6.26 annotation is correctly placed for the get_sub_field_input_attrs() method in the parent class.

classes/models/fields/FrmFieldType.php (1)

2055-2055: LGTM!

The @since 6.26 annotation is correctly placed for the filter_value_for_table_html() method.

classes/controllers/FrmFormsController.php (1)

3321-3321: LGTM!

Good documentation practice. The @since 6.26 annotation correctly documents the visibility change from private to public for the message_placement() method, while preserving the original @since 4.05.02 annotation for when the method was first introduced.

classes/controllers/FrmAppController.php (1)

968-1003: Docblock @SInCE values correctly aligned to 6.26

The @since annotations for maybe_deregister_popper1 and register_popper2 now match the 6.26 release, with no behavioral changes in the methods themselves.

formidable.php (1)

3-8: Plugin header version correctly bumped to 6.26

The main file’s Version: header now matches the new release number and the helper constant; no runtime impact.

classes/helpers/FrmAppHelper.php (3)

28-46: Core plugin version constant updated to 6.26

FrmAppHelper::$plug_version now matches the plugin header and will propagate 6.26 wherever plugin_version() is used.


194-219: pull_medium_from_link @SInCE annotation updated to 6.26

The @since tag now reflects its introduction in 6.26; implementation is unchanged and remains a safe helper around parse_url/wp_parse_args.


5054-5083: Doc URL helper and deprecation metadata aligned with 6.26

  • get_doc_url() is documented as @since 6.26, matching the new minor release.
  • show_landing_pages() is now marked @deprecated 6.26 and passes '6.26' to _deprecated_function, keeping deprecation metadata consistent.

Behavior of both methods is unchanged (the deprecated method still returns true), so this is a safe metadata-only update.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Crabcyborg Crabcyborg merged commit ba5b48a into master Dec 9, 2025
34 of 36 checks passed
@Crabcyborg Crabcyborg deleted the prepare_for_6.26 branch December 9, 2025 15:36
@coderabbitai coderabbitai Bot mentioned this pull request Dec 16, 2025
stephywells pushed a commit that referenced this pull request Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant