Skip to content

Fix issues with duplicating Section field #2648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AbdiTolesa wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Fix issues with duplicating Section field #2648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
83dcf42
Fix section getting half width when duplicated with group
AbdiTolesa Dec 10, 2025
c413751
Fix more issues with duplicating section fields
AbdiTolesa Dec 12, 2025
28352c9
Reduce code repetition
AbdiTolesa Dec 12, 2025
5219df7
Rebuild Files
AbdiTolesa Dec 12, 2025
1eceed8
Fix merge conflict
AbdiTolesa Dec 24, 2025
6824901
Build files
AbdiTolesa Dec 24, 2025
75e5832
Fix issue with drag and drop after field group is broke apart
AbdiTolesa Dec 26, 2025
7443501
Sync layout classes after duplicating field group of sections
AbdiTolesa Dec 26, 2025
cbbb847
Fix layout classes not syncing for the last field after duplicating g…
AbdiTolesa Dec 30, 2025
204b212
Fix merge conflicts
AbdiTolesa Dec 30, 2025
f2207d9
Fix eslint errors
AbdiTolesa Dec 30, 2025
f7677e3
Fix merge conflict with master branch
AbdiTolesa Jan 1, 2026
12f8738
Rename function
AbdiTolesa Jan 5, 2026
c3886dc
Fix merge conflict
AbdiTolesa Jan 5, 2026
2271b13
Fix code style in css file
AbdiTolesa Jan 12, 2026
48977ce
Merge master
AbdiTolesa Jan 12, 2026
f8c6e14
Fix more spacing errors in a css file
AbdiTolesa Jan 12, 2026
ef8d05a
Rebuild files
AbdiTolesa Jan 13, 2026
3ee3ea3
Solve merge conflict
AbdiTolesa Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/formidable_admin.js
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions js/formidable_styles.js.map
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions js/onboarding-wizard.js.map
View file
Open in desktop

Large diffs are not rendered by default.

22 changes: 18 additions & 4 deletions js/src/admin/admin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2385,6 +2385,11 @@ window.frmAdminBuildJS = function() {
fieldOrder = this.getAttribute( 'frm-field-order' );
}

const getSectionField = $fieldObject => {
const liElement = $fieldObject.get( 0 ).querySelector( 'ul li[data-ftype="divider"]' );
return liElement ? jQuery( liElement ) : $fieldObject;
};

jQuery.ajax( {
type: 'POST',
url: ajaxurl,
Expand All @@ -2404,7 +2409,10 @@ window.frmAdminBuildJS = function() {
newRow = document.getElementById( newRowId );
if ( null !== newRow ) {
replaceWith = msgAsjQueryObject( msg );
jQuery( newRow ).append( replaceWith );
const newField = getSectionField( replaceWith );

jQuery( newRow ).append( newField );

makeDraggable( replaceWith.get( 0 ), '.frm-move' );
if ( null !== fieldOrder ) {
newRow.lastElementChild.setAttribute( 'frm-field-order', fieldOrder );
Expand All @@ -2424,12 +2432,18 @@ window.frmAdminBuildJS = function() {

if ( $field.siblings( 'li.form-field' ).length ) {
replaceWith = msgAsjQueryObject( msg );
$field.after( replaceWith );
const newField = getSectionField( replaceWith );
$field.after( newField );
syncLayoutClasses( $field );
makeDraggable( replaceWith.get( 0 ), '.frm-move' );

const layoutClass = getLayoutClassName( $field.get( 0 ).classList );
if ( ! newField.get( 0 ).classList.contains( layoutClass ) ) {
newField.get( 0 ).classList.add( layoutClass );
}
} else {
replaceWith = wrapFieldLi( msg );
$field.parent().parent().after( replaceWith );
$field.parent().parent().after( getSectionField( replaceWith ) );
makeDroppable( replaceWith.get( 0 ).querySelector( 'ul.frm_sorting' ) );
makeDraggable( replaceWith.get( 0 ).querySelector( 'li.form-field' ), '.frm-move' );
}
Expand Down Expand Up @@ -6888,7 +6902,7 @@ window.frmAdminBuildJS = function() {
replaceWith = replaceWith.trim();
}

field.className = field.className.replace( replace, replaceWith );
field.className = field.className.replace( /\s+/g, ' ' ).replace( replace, replaceWith );
}

function maybeShowInlineModal( e ) {
Expand Down