Skip to content

Treat another code sniffer warning as error (superfluous whitespace)#2650

Merged
Crabcyborg merged 1 commit into
masterfrom
treat_another_code_sniffer_warning_as_error
Dec 12, 2025
Merged

Treat another code sniffer warning as error (superfluous whitespace)#2650
Crabcyborg merged 1 commit into
masterfrom
treat_another_code_sniffer_warning_as_error

Conversation

@Crabcyborg
Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Dec 12, 2025

Walkthrough

Four files updated with PHPDoc formatting corrections: trailing whitespace removed and blank parameter lines properly aligned in documentation comments. No functional changes, signature modifications, or control flow alterations.

Changes

Cohort / File(s) Summary
PHPDoc Formatting Fixes
classes/controllers/FrmFormActionsController.php, classes/helpers/FrmEntriesListHelper.php, classes/helpers/FrmOnSubmitHelper.php, classes/models/FrmEntryMeta.php
Trailing whitespace removed and blank lines realigned in @param annotations across PHPDoc blocks for methods including trigger_create_actions, trigger_actions, search_box, display_tablenav, extra_tablenav, and update_entry_meta. No functional or signature changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • All changes are repetitive whitespace/formatting adjustments in documentation comments with zero functional impact
  • No logic, behavior, or signatures affected

Possibly related PRs

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess whether it relates to the changeset. Add a description explaining the purpose of removing superfluous whitespace and how it addresses code sniffer warnings.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Treat another code sniffer warning as error (superfluous whitespace)' directly and specifically describes the main change in the pull request: removing trailing whitespace from PHPDoc blocks across multiple files to comply with code sniffer standards.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch treat_another_code_sniffer_warning_as_error

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b00a2ec and 162afff.

⛔ Files ignored due to path filters (1)
  • phpcs.xml is excluded by !**/*.xml
📒 Files selected for processing (4)
  • classes/controllers/FrmFormActionsController.php (2 hunks)
  • classes/helpers/FrmEntriesListHelper.php (2 hunks)
  • classes/helpers/FrmOnSubmitHelper.php (1 hunks)
  • classes/models/FrmEntryMeta.php (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: Cypress
  • GitHub Check: PHP 7.4 tests in WP trunk
  • GitHub Check: PHP 8 tests in WP trunk
  • GitHub Check: PHP 8 tests in WP trunk
  • GitHub Check: PHP 7.4 tests in WP trunk
  • GitHub Check: Cypress
🔇 Additional comments (5)
classes/helpers/FrmOnSubmitHelper.php (1)

462-473: Docblock whitespace cleanup looks good (no behavior change).
Line 467 updates only PHPDoc formatting for FrmOnSubmitHelper::current_event; the method logic is untouched.

classes/models/FrmEntryMeta.php (1)

83-91: Docblock whitespace cleanup looks good (no behavior change).
Line 86 adjusts only PHPDoc formatting for FrmEntryMeta::set_value_before_save.

classes/helpers/FrmEntriesListHelper.php (2)

245-268: Docblock whitespace cleanup looks good (no behavior change).
Line 246 removes superfluous whitespace in the @param string $which doc for display_tablenav; implementation/signature unchanged.


270-290: Docblock whitespace cleanup looks good (no behavior change).
Line 271 removes superfluous whitespace in the @param string $which doc for extra_tablenav; implementation/signature unchanged.

classes/controllers/FrmFormActionsController.php (1)

621-654: Docblock alignment cleanup looks good (no behavior change).
Lines 625 and 651 adjust only PHPDoc formatting around trigger_create_actions / trigger_actions; code paths and signatures remain unchanged.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Crabcyborg Crabcyborg merged commit fb0e39e into master Dec 12, 2025
36 checks passed
@Crabcyborg Crabcyborg deleted the treat_another_code_sniffer_warning_as_error branch December 12, 2025 13:54
@Crabcyborg Crabcyborg modified the milestones: 6.27, 6.26.1 Dec 12, 2025
stephywells pushed a commit that referenced this pull request Apr 4, 2026
…arning_as_error

Treat another code sniffer warning as error (superfluous whitespace)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant