Skip to content

Remove some phpstan exceptions after updating to v2 and fix some small issues #2673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 1 commit into from
Dec 18, 2025
Merged

Remove some phpstan exceptions after updating to v2 and fix some small issues #2673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion classes/helpers/FrmEntriesListHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,7 @@ private function get_actions( &$actions, $item, $view_link ) {

/**
* @param object $item
* @param false $val
* @param mixed $val
*
* @return void
*/
Expand Down
2 changes: 1 addition & 1 deletion classes/helpers/FrmFieldGridHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
class FrmFieldGridHelper {

/**
* @var bool|string
* @var bool
*/
private $parent_li;

Expand Down
2 changes: 1 addition & 1 deletion classes/views/styles/components/FrmStyleComponent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class FrmStyleComponent {
*
* @since 6.14
*
* @var stdClass|null
* @var FrmStyleComponent|null
*/
private static $instance;

Expand Down
7 changes: 4 additions & 3 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,15 +258,16 @@ parameters:
- message: '#Cannot access an offset on mixed#'
- message: '#might not exist on#'
- message: '#is not a file or it does not exist#'
- message: '#so it can be removed from the property type#'
- message: '#Cannot use \+\+ on mixed#'
- message: '#Cannot use -- on mixed#'
- message: '#Cannot use array destructuring on mixed#'
- message: '#always exists and is not nullable#'
- message: '#Possibly invalid array key#'
- message: '#should return string but returns float#'
- message: '#should return array<(string|array)> but returns array#'
-
message: '#should return string but returns float#'
path: classes/models/FrmEmailStats.php
- message: '#on a separate line has no effect#'
- message: '#but returns array#'
- message: '#Cannot clone non-object variable#'
- message: '#so it can be removed from the by-ref type#'
- message: '#function array_map expects#'
Expand Down
Loading