Drop references to deprecated actions dropdown and deprecated actions_dropdown function/view#2685
Conversation
actions_dropdown function
actions_dropdown functionactions_dropdown function/view
WalkthroughThis PR removes a deprecated actions dropdown method from the FrmFormsHelper class, deletes its associated view template, and removes all related CSS styling rules for the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
css/frm_testing_mode.css (1)
3-3: Address CSS quality issues in source SCSS files.Static analysis identified several CSS quality issues in the compiled output:
- Duplicate
text-alignproperties (where the second overrides the first)- Duplicate
min-widthproperties- Duplicate
border-radiuspropertiesbackgroundshorthand appearing afterbackground-color(can cause unexpected behavior)Since this appears to be compiled CSS, these issues should be fixed in the source SCSS files (e.g.,
resources/scss/admin/components/...) and then recompiled. Removing duplicate properties will reduce file size and prevent confusion about which value is actually applied.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
classes/helpers/FrmFormsHelper.phpclasses/views/frm-forms/actions-dropdown.phpcss/frm_admin.csscss/frm_testing_mode.cssresources/scss/admin/components/select/_dropdown.scssresources/scss/admin/components/table/_elements.scssresources/scss/admin/media-queries/_screen-mobile.scssresources/scss/admin/rtl/_general.scss
💤 Files with no reviewable changes (6)
- resources/scss/admin/rtl/_general.scss
- resources/scss/admin/components/table/_elements.scss
- resources/scss/admin/components/select/_dropdown.scss
- resources/scss/admin/media-queries/_screen-mobile.scss
- classes/helpers/FrmFormsHelper.php
- classes/views/frm-forms/actions-dropdown.php
🧰 Additional context used
🪛 Biome (2.1.2)
css/frm_testing_mode.css
[error] 3-3: Unexpected shorthand property background after background-color
(lint/suspicious/noShorthandPropertyOverrides)
[error] 3-3: Duplicate properties can lead to unexpected behavior and may override previous declarations unintentionally.
text-align is already defined here.
Remove or rename the duplicate property to ensure consistent styling.
(lint/suspicious/noDuplicateProperties)
[error] 3-3: Duplicate properties can lead to unexpected behavior and may override previous declarations unintentionally.
min-width is already defined here.
Remove or rename the duplicate property to ensure consistent styling.
(lint/suspicious/noDuplicateProperties)
[error] 3-3: Duplicate properties can lead to unexpected behavior and may override previous declarations unintentionally.
border-radius is already defined here.
Remove or rename the duplicate property to ensure consistent styling.
(lint/suspicious/noDuplicateProperties)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: PHP 8 tests in WP trunk
- GitHub Check: PHP 7.4 tests in WP trunk
- GitHub Check: PHP 7.4 tests in WP trunk
- GitHub Check: PHP 8 tests in WP trunk
- GitHub Check: Cypress
- GitHub Check: Cypress
🔇 Additional comments (1)
css/frm_testing_mode.css (1)
3-3: Tooltip re-enablement is intentional and safe.The Bootstrap tooltip CSS on line 3 is being uncommented to restore tooltip functionality used throughout the admin interface (visible in
js/src/frm_testing_mode.jsandjs/src/admin/admin.js). No conflicts detected—the JavaScript already initializes these tooltips, and the patterntext-align:left;text-align:start;is a standard Bootstrap v4.6.1 fallback for browser compatibility.Since this file is compiled output from
resources/scss/test-mode/frm_testing_mode.scss, any CSS refinements should be made in the SCSS source files and recompiled rather than edited directly in this minified output.
…d_actions_dropdown Drop references to deprecated actions dropdown and deprecated `actions_dropdown` function/view
No description provided.