Skip to content

Drop references to deprecated actions dropdown and deprecated actions_dropdown function/view#2685

Merged
Crabcyborg merged 2 commits into
masterfrom
drop_references_to_deprecated_actions_dropdown
Dec 29, 2025
Merged

Drop references to deprecated actions dropdown and deprecated actions_dropdown function/view#2685
Crabcyborg merged 2 commits into
masterfrom
drop_references_to_deprecated_actions_dropdown

Conversation

@Crabcyborg
Copy link
Copy Markdown
Contributor

No description provided.

@Crabcyborg Crabcyborg added this to the 6.27 milestone Dec 29, 2025
@Crabcyborg Crabcyborg changed the title Drop references to deprecated actions dropdown Drop references to deprecated actions dropdown and deprecated actions_dropdown function Dec 29, 2025
@Crabcyborg Crabcyborg changed the title Drop references to deprecated actions dropdown and deprecated actions_dropdown function Drop references to deprecated actions dropdown and deprecated actions_dropdown function/view Dec 29, 2025
@Crabcyborg Crabcyborg merged commit 498947f into master Dec 29, 2025
36 checks passed
@Crabcyborg Crabcyborg deleted the drop_references_to_deprecated_actions_dropdown branch December 29, 2025 18:08
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Dec 29, 2025

Walkthrough

This PR removes a deprecated actions dropdown method from the FrmFormsHelper class, deletes its associated view template, and removes all related CSS styling rules for the .frm_actions_dropdown selector across multiple SCSS files. Additionally, Bootstrap tooltip CSS is re-enabled.

Changes

Cohort / File(s) Summary
PHP Deprecation Cleanup
classes/helpers/FrmFormsHelper.php, classes/views/frm-forms/actions-dropdown.php
Removed the deprecated public static function actions_dropdown( $atts ) method and its associated dropdown view template that rendered the WP admin UI dropdown for form actions.
Dropdown Styling Removal
resources/scss/admin/components/select/_dropdown.scss, resources/scss/admin/components/table/_elements.scss, resources/scss/admin/media-queries/_screen-mobile.scss, resources/scss/admin/rtl/_general.scss
Removed all CSS rules targeting .frm_actions_dropdown across multiple SCSS files, including font sizing, color, float positioning, RTL-specific alignment, and mobile layout adjustments.
Testing Mode CSS
css/frm_testing_mode.css
Re-enabled Bootstrap tooltip CSS by adjusting comment boundaries to activate previously commented-out tooltip styles.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • lauramekaj1
  • truongwp

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess relevance to the changeset. Add a brief description explaining why the deprecated actions dropdown is being removed and any migration path for users.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'Drop references to deprecated actions dropdown' accurately and concisely summarizes the primary change: removing deprecated code references related to the actions dropdown component.
✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
css/frm_testing_mode.css (1)

3-3: Address CSS quality issues in source SCSS files.

Static analysis identified several CSS quality issues in the compiled output:

  • Duplicate text-align properties (where the second overrides the first)
  • Duplicate min-width properties
  • Duplicate border-radius properties
  • background shorthand appearing after background-color (can cause unexpected behavior)

Since this appears to be compiled CSS, these issues should be fixed in the source SCSS files (e.g., resources/scss/admin/components/...) and then recompiled. Removing duplicate properties will reduce file size and prevent confusion about which value is actually applied.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 353a3f5 and 3015b41.

📒 Files selected for processing (8)
  • classes/helpers/FrmFormsHelper.php
  • classes/views/frm-forms/actions-dropdown.php
  • css/frm_admin.css
  • css/frm_testing_mode.css
  • resources/scss/admin/components/select/_dropdown.scss
  • resources/scss/admin/components/table/_elements.scss
  • resources/scss/admin/media-queries/_screen-mobile.scss
  • resources/scss/admin/rtl/_general.scss
💤 Files with no reviewable changes (6)
  • resources/scss/admin/rtl/_general.scss
  • resources/scss/admin/components/table/_elements.scss
  • resources/scss/admin/components/select/_dropdown.scss
  • resources/scss/admin/media-queries/_screen-mobile.scss
  • classes/helpers/FrmFormsHelper.php
  • classes/views/frm-forms/actions-dropdown.php
🧰 Additional context used
🪛 Biome (2.1.2)
css/frm_testing_mode.css

[error] 3-3: Unexpected shorthand property background after background-color

(lint/suspicious/noShorthandPropertyOverrides)


[error] 3-3: Duplicate properties can lead to unexpected behavior and may override previous declarations unintentionally.

text-align is already defined here.

Remove or rename the duplicate property to ensure consistent styling.

(lint/suspicious/noDuplicateProperties)


[error] 3-3: Duplicate properties can lead to unexpected behavior and may override previous declarations unintentionally.

min-width is already defined here.

Remove or rename the duplicate property to ensure consistent styling.

(lint/suspicious/noDuplicateProperties)


[error] 3-3: Duplicate properties can lead to unexpected behavior and may override previous declarations unintentionally.

border-radius is already defined here.

Remove or rename the duplicate property to ensure consistent styling.

(lint/suspicious/noDuplicateProperties)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: PHP 8 tests in WP trunk
  • GitHub Check: PHP 7.4 tests in WP trunk
  • GitHub Check: PHP 7.4 tests in WP trunk
  • GitHub Check: PHP 8 tests in WP trunk
  • GitHub Check: Cypress
  • GitHub Check: Cypress
🔇 Additional comments (1)
css/frm_testing_mode.css (1)

3-3: Tooltip re-enablement is intentional and safe.

The Bootstrap tooltip CSS on line 3 is being uncommented to restore tooltip functionality used throughout the admin interface (visible in js/src/frm_testing_mode.js and js/src/admin/admin.js). No conflicts detected—the JavaScript already initializes these tooltips, and the pattern text-align:left;text-align:start; is a standard Bootstrap v4.6.1 fallback for browser compatibility.

Since this file is compiled output from resources/scss/test-mode/frm_testing_mode.scss, any CSS refinements should be made in the SCSS source files and recompiled rather than edited directly in this minified output.

stephywells pushed a commit that referenced this pull request Apr 4, 2026
…d_actions_dropdown

Drop references to deprecated actions dropdown and deprecated `actions_dropdown` function/view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant