Ignore phpstan errors in fewer files

[Crabcyborg]

Bumping the baseline so these rules are enforced in most files.

[coderabbitai]

Walkthrough

Reworks PHPStan ignoreErrors in phpstan.neon, replacing several global ignore patterns with file-scoped ignore blocks for specific messages (e.g., "but returns mixed", "mixed given", "cannot be converted to string.", "Cannot access an offset on mixed", "array_map expects", "array given") across many PHP files.

Changes

Cohort / File(s)	Summary
PHPStan configuration phpstan.neon	Converted multiple global ignoreErrors patterns into per-path blocks. Added file-scoped ignores for messages including "but returns mixed", "mixed given", "cannot be converted to string.", "Cannot access an offset on mixed", "function array_map expects", and "array given", targeting numerous controllers, helpers, models, view files, and Stripe/Square-related files.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Remove some phpstan exceptions after updating to v2 and fix some small issues #2673: Also modifies phpstan.neon to move global ignore rules into file-scoped entries.
• Move some phpstan exceptions to problematic files only #2236: Narrows global PHPStan ignore patterns into per-file/path-scoped blocks in phpstan.neon.
• phpstan config updates and remove another private unused function #2658: Converts broad global PHPStan ignores to granular path-scoped ignore entries in phpstan.neon.

Pre-merge checks

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Ignore phpstan errors in fewer files' directly describes the main change: converting global PHPStan error ignores to per-file scopes, reducing the number of files with broad ignore rules.
Description check	✅ Passed	The description 'Bumping the baseline so these rules are enforced in most files' clearly relates to the changeset, explaining the purpose of moving from global to file-specific PHPStan error configurations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

phpstan.neon (2)

255-278: Good improvement to enforce stricter type safety.

Converting global error suppressions to file-specific ones is a solid step toward improving type safety across the codebase. This ensures that new code in other files won't be allowed to return mixed types without proper type declarations.

Consider creating a plan to gradually fix the underlying type safety issues in these 21 files to fully eliminate this suppression.

---

335-335: Remove trailing whitespace.

There are extra spaces at the end of this line. While YAML tolerates trailing whitespace, it's cleaner to remove it.

🔎 Proposed fix

-				- classes/helpers/FrmAppHelper.php  
+				- classes/helpers/FrmAppHelper.php

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7f049ce and 1ec754e.

📒 Files selected for processing (1)

• phpstan.neon

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Cypress
• GitHub Check: PHP 8 tests in WP 6.9
• GitHub Check: PHP 7.4 tests in WP 6.9

🔇 Additional comments (1)

phpstan.neon (1)

341-343: Pattern #array given# is too generic and could suppress multiple unrelated errors.

The pattern would match any PHPStan error containing "array given"—for example, "expects string but array given", "expects object but array given", etc. Given FrmFieldsHelper.php has numerous functions with specific array parameter type hints, this single pattern likely suppresses multiple distinct error types.

Make the pattern more specific by including the parameter type expectation, such as #expects string but array given#, or identify the exact error message(s) by running PHPStan on the file.