Skip to content

Add new php code sniffer rule to prevent useless new line at start of…#2749

Merged
Crabcyborg merged 1 commit into
masterfrom
add_new_php_code_sniffer_rule_to_prevent_useless_new_line_at_start_of_function
Jan 9, 2026
Merged

Add new php code sniffer rule to prevent useless new line at start of…#2749
Crabcyborg merged 1 commit into
masterfrom
add_new_php_code_sniffer_rule_to_prevent_useless_new_line_at_start_of_function

Conversation

@Crabcyborg
Copy link
Copy Markdown
Contributor

… function

@Crabcyborg Crabcyborg added this to the 6.27 milestone Jan 9, 2026
@Crabcyborg Crabcyborg changed the title Add new php code sniffer rule to prevent useless new lien at start of… Add new php code sniffer rule to prevent useless new line at start of… Jan 9, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 9, 2026

Walkthrough

This pull request systematically removes extraneous blank lines across 17 PHP files spanning controllers, helpers, models, views, tests, and the stripe module. All changes are whitespace-only formatting adjustments with no behavioral, logic, or control-flow modifications.

Changes

Cohort / File(s) Summary
Controllers
classes/controllers/FrmDashboardController.php, classes/controllers/FrmSMTPController.php
Removed blank lines after method openings and within helper methods (view_args_build_counter, view_args_payments, view_args_entries_placeholder, enqueue_assets, inbox_clean_messages_cta, load_hooks, output_section_, get_data_step_, is_smtp_configured)
Helpers
classes/helpers/FrmEntriesHelper.php, classes/helpers/FrmFieldsHelper.php
Removed blank lines after method signatures in display_value, get_entry_statuses, setup_new_vars, and get_display_value
Models
classes/models/FrmAddon.php, classes/models/FrmEmail.php, classes/models/FrmEntry.php, classes/models/FrmEntryValues.php, classes/models/FrmForm.php, classes/models/FrmFormMigrator.php, classes/models/FrmMigrate.php, classes/models/FrmReviews.php, classes/models/FrmSolution.php, classes/models/FrmTableHTMLGenerator.php
Removed blank lines from method bodies (__construct, edd_plugin_updater, plugins_api_filter, handle_phone_numbers, before_insert_entry_in_database, after_insert_entry_in_database, init_include_fields, get_latest_form, get_forms_count, import_page, import_forms, import_form, add_form, track_import, migrate_to_86, review_request, review, register, redirect, tr_style)
Views
classes/views/styles/components/FrmSliderStyleComponent.php
Removed blank lines after constructor signature and at start of init_icon method
Stripe
stripe/models/FrmTransLiteAction.php
Removed blank line at start of get_field_options method
Tests
tests/phpunit/entries/test_FrmShowEntryShortcode.php, tests/phpunit/fields/test_FrmFieldType.php, tests/phpunit/misc/test_FrmAppController.php, tests/phpunit/misc/test_FrmOverlayController.php
Removed blank lines before conditional checks and variable assignments in test methods

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

run analysis, run tests

Suggested reviewers

  • lauramekaj1
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description '… function' is a continuation of the title and relates to the changeset, though it is incomplete and vague.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title describes the main objective of the PR: adding a new PHP code sniffer rule to prevent unnecessary blank lines at the start of functions, which directly aligns with the changeset containing whitespace cleanup across multiple files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Crabcyborg Crabcyborg merged commit 68bf7c6 into master Jan 9, 2026
35 of 36 checks passed
@Crabcyborg Crabcyborg deleted the add_new_php_code_sniffer_rule_to_prevent_useless_new_line_at_start_of_function branch January 9, 2026 13:18
stephywells pushed a commit that referenced this pull request Apr 4, 2026
…e_to_prevent_useless_new_line_at_start_of_function

Add new php code sniffer rule to prevent useless new line at start of…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant