Add new sniff to enforce more consistent spacing within functions

classes/controllers/FrmAddonsController.php

@@ -407,6 +407,7 @@ protected static function fallback_plugin_list() {
 			$info['slug'] = $k;
 			$list[ $k ]   = array_merge( $defaults, $info );
 		}
+
 		return $list;
 	}
 
@@ -742,6 +743,7 @@ public static function get_addon( $plugin ) {
 				return $addon;
 			}
 		}
+
 		return false;
 	}
 
@@ -757,6 +759,7 @@ protected static function get_license_type() {
 		if ( isset( $addons['error'] ) && isset( $addons['error']['type'] ) ) {
 			$license_type = $addons['error']['type'];
 		}
+
 		return $license_type;
 	}
 
@@ -1113,6 +1116,7 @@ protected static function install_addon() {
 				'success' => false,
 			);
 		}
+
 		return $plugin;
 	}
 
@@ -1230,6 +1234,7 @@ protected static function handle_addon_action( $installed, $action ) {
 				if ( wp_doing_ajax() ) {
 					wp_send_json_error( array( 'error' => $result->get_error_message() ) );
 				}
+
 				return array(
 					'message' => $result->get_error_message(),
 					'success' => false,

classes/controllers/FrmAppController.php

@@ -142,6 +142,7 @@ private static function get_os() {
 		} elseif ( str_contains( $agent, 'windows' ) ) {
 			$os = ' windows';
 		}
+
 		return $os;
 	}
 
@@ -1459,6 +1460,7 @@ private static function in_our_pages() {
 		if ( ! empty( $current_screen->post_type ) && 'frm_logs' === $current_screen->post_type ) {
 			return true;
 		}
+
 		return in_array( $pagenow, array( 'term.php', 'edit-tags.php' ), true ) && 'frm_application' === FrmAppHelper::simple_get( 'taxonomy' );
 	}
 

classes/controllers/FrmDashboardController.php

@@ -531,6 +531,7 @@ private static function get_dashboard_options( $option_name = null ) {
 		if ( null !== $option_name ) {
 			return $options[ $option_name ];
 		}
+
 		return $options;
 	}
 

classes/controllers/FrmFieldsController.php

@@ -903,6 +903,7 @@ private static function get_form_for_js_validation( $field ) {
 				return $frm_vars['js_validate_forms'][ $field['parent_form_id'] ];
 			}
 		}
+
 		return false;
 	}
 

classes/controllers/FrmFormActionsController.php

@@ -253,6 +253,7 @@ private static function active_actions( $action_controls ) {
 				$allowed[] = $action_control->id_base;
 			}
 		}
+
 		return $allowed;
 	}
 

classes/controllers/FrmSettingsController.php

@@ -243,6 +243,7 @@ private static function payment_sections_sort_callback( $a, $b ) {
 		if ( false === $first_key || false === $second_key ) {
 			return 0;
 		}
+
 		return $first_key - $second_key;
 	}
 

classes/controllers/FrmSimpleBlocksController.php

@@ -231,6 +231,7 @@ public static function simple_form_render( $attributes ) {
 		if ( ! empty( $attributes['className'] ) ) {
 			$form = preg_replace( '/\bfrm_forms\b/', 'frm_forms ' . esc_attr( $attributes['className'] ), $form, 1 );
 		}
+
 		return self::maybe_remove_fade_on_load_for_block_preview( $form );
 	}
 

classes/controllers/FrmStylesController.php

@@ -876,6 +876,7 @@ public static function get_custom_css( $single_style_settings = null ) {
 			if ( ! empty( $single_style_settings['single_style_custom_css'] ) && ! empty( $single_style_settings['enable_style_custom_css'] ) ) {
 				return $single_style_settings['single_style_custom_css'];
 			}
+
 			return '';
 		}
 

classes/controllers/FrmUsageController.php

@@ -32,6 +32,7 @@ public static function schedule_send() {
 				// Remove the scheduled event if it's not allowed and it's scheduled.
 				wp_unschedule_event( $timestamp, 'formidable_send_usage' );
 			}
+
 			return;
 		}
 

classes/controllers/FrmXMLController.php

@@ -148,6 +148,7 @@ private static function get_posted_form() {
 		if ( ! $form ) {
 			return $form;
 		}
+
 		return json_decode( $form, true );
 	}
 

classes/helpers/FrmApiHelper.php

@@ -39,6 +39,7 @@ public static function is_for_user( $item ) {
 		if ( in_array( 'free_not_first_30', $who, true ) && self::is_free_not_first_30() ) {
 			return true;
 		}
+
 		return self::check_free_segments( $who );
 	}
 

classes/helpers/FrmAppHelper.php

@@ -428,6 +428,7 @@ public static function is_form_builder_page( $check_for_settings = true ) {
 		if ( $check_for_settings ) {
 			$check_actions[] = 'settings';
 		}
+
 		return self::is_admin_page( 'formidable' ) && in_array( $action, $check_actions, true );
 	}
 
@@ -903,6 +904,7 @@ public static function sanitize_value( $sanitize, &$value ) {
 			foreach ( $temp_values as $k => $v ) {
 				self::sanitize_value( $sanitize, $value[ $k ] );
 			}
+
 			return;
 		}
 
@@ -1103,6 +1105,7 @@ public static function kses_submit_button( $html ) {
 		if ( $included_draft_hook ) {
 			$html = str_replace( 'class="frm_save_draft"', 'class="frm_save_draft" [draft_hook]', $html );
 		}
+
 		return $html;
 	}
 
@@ -1484,6 +1487,7 @@ private static function is_a_valid_color( $value ) {
 		} elseif ( str_starts_with( $value, '#' ) ) {
 			$match = preg_match( '/^#([a-f0-9]{6}|[a-f0-9]{3})\b$/', $value );
 		}
+
 		return (bool) $match;
 	}
 
@@ -2767,6 +2771,7 @@ private static function maybe_truncate_key_before_appending( $column, $key ) {
 				}
 			}
 		}
+
 		return $key;
 	}
 
@@ -2823,6 +2828,7 @@ private static function prevent_numeric_and_reserved_keys( $key ) {
 				$key .= 'a';
 			}
 		}
+
 		return $key;
 	}
 
@@ -3358,6 +3364,7 @@ private static function get_unit( $unit ) {
 				return $u;
 			}
 		}
+
 		return 1;
 	}
 
@@ -3723,6 +3730,7 @@ public static function maybe_utf8_encode( $value ) {
 			if ( mb_check_encoding( $value, $from_format ) ) {
 				return mb_convert_encoding( $value, $to_format, $from_format );
 			}
+
 			return $value;
 		}
 
@@ -4230,6 +4238,7 @@ public static function get_menu_icon_class() {
 				return $settings->menu_icon;
 			}
 		}
+
 		return 'frmfont frm_logo_icon';
 	}
 
@@ -5014,6 +5023,7 @@ public static function is_valid_utf8( $string ) {
 		if ( function_exists( 'seems_utf8' ) ) {
 			return seems_utf8( $string );
 		}
+
 		return false;
 	}
 

classes/helpers/FrmCSVExportHelper.php

@@ -649,6 +649,7 @@ private static function get_field( $field_id ) {
 				return $field;
 			}
 		}
+
 		return false;
 	}
 

classes/helpers/FrmCurrencyHelper.php

@@ -25,6 +25,7 @@ public static function get_currency( $currency ) {
 		} else {
 			$currency = $currencies['USD'];
 		}
+
 		return $currency;
 	}
 

classes/helpers/FrmEmailHelper.php

@@ -54,6 +54,7 @@ public static function get_default_from_email() {
 		if ( $settings->from_email && is_email( $settings->from_email ) ) {
 			return $settings->from_email;
 		}
+
 		return get_option( 'admin_email' );
 	}
 }

classes/helpers/FrmFieldGridHelper.php

@@ -162,6 +162,7 @@ private function should_first_close_the_active_field_wrapper() {
 		if ( 'end_divider' === $this->field->type ) {
 			return false;
 		}
+
 		return ! $this->can_support_current_layout() || $this->is_frm_first;
 	}
 
@@ -226,6 +227,7 @@ public function sync_list_size() {
 			if ( 'end_divider' === $this->field->type ) {
 				$this->maybe_close_section_helper();
 			}
+
 			return;
 		}
 

classes/helpers/FrmFieldsHelper.php

@@ -502,6 +502,7 @@ private static function maybe_replace_substrings_with_field_name( $msg, $error,
 		if ( ! $field_name ) {
 			$field_name = 'unique_msg' === $error ? __( 'This value', 'formidable' ) : __( 'This field', 'formidable' );
 		}
+
 		return str_replace( $substrings, $field_name, $msg );
 	}
 
@@ -1130,6 +1131,7 @@ private static function trigger_shortcode_atts( $replace_with, $atts ) {
 			$function     = 'atts_' . $included_att;
 			$replace_with = self::$function( $replace_with );
 		}
+
 		return $replace_with;
 	}
 
@@ -1862,6 +1864,7 @@ private static function switch_ids_except_strings( $replace, $replace_with, $exc
 			unset( $replace[ $index ] );
 			unset( $replace_with[ $index ] );
 		}
+
 		return str_replace( $replace, $replace_with, $value );
 	}
 

classes/helpers/FrmFormMigratorsHelper.php

@@ -86,6 +86,7 @@ private static function import_links() {
 
 			$forms[] = $form;
 		}
+
 		return $forms;
 	}
 

classes/helpers/FrmFormsHelper.php

@@ -1004,6 +1004,7 @@ public static function get_form_style_class( $form = false ) {
 			if ( FrmAppHelper::is_admin_page( 'formidable-entries' ) ) {
 				return $class;
 			}
+
 			return null;
 		}
 
@@ -1304,6 +1305,7 @@ public static function edit_form_link_label( $data ) {
 		if ( ! $name ) {
 			return self::get_no_title_text();
 		}
+
 		return FrmAppHelper::truncate( $name, 40 );
 	}
 
@@ -2077,6 +2079,7 @@ public static function form_is_loaded_by_api() {
 		if ( ! empty( $frm_vars['inplace_edit'] ) ) {
 			return true;
 		}
+
 		return self::is_formidable_api_form() || self::is_gutenberg_editor() || self::is_elementor_ajax() || self::is_visual_views_preview();
 	}
 

classes/helpers/FrmShortcodeHelper.php

@@ -79,6 +79,7 @@ public static function get_contextual_codes() {
 		foreach ( $contextual_shortcodes as $type => $shortcodes ) {
 			$result[ $type ] = array_keys( $shortcodes );
 		}
+
 		return $result;
 	}
 

classes/helpers/FrmStringReaderHelper.php

@@ -55,6 +55,7 @@ public function read_until( $char ) {
 		while ( $this->pos <= $this->max && ( $one = $this->string[ $this->pos++ ] ) !== $char ) {
 			$value .= $one;
 		}
+
 		return $value;
 	}
 

classes/helpers/FrmStylesHelper.php

@@ -252,6 +252,7 @@ private static function get_rgb_array_from_rgb( $rgb ) {
 			// Drop the alpha. The function is expected to only return r,g,b with no alpha.
 			array_pop( $rgb );
 		}
+
 		return $rgb;
 	}
 
@@ -1156,6 +1157,7 @@ public static function get_bottom_value( $value ) {
 		if ( count( $parts ) < 3 ) {
 			return $parts[0];
 		}
+
 		return $parts[2];
 	}
 }

classes/helpers/FrmSubmitHelper.php

@@ -212,6 +212,7 @@ public static function only_contains_submit_field( $fields ) {
 
 			$submit_field = $field;
 		}
+
 		return $submit_field;
 	}
 

classes/helpers/FrmTipsHelper.php

@@ -95,6 +95,7 @@ private static function get_tip_link( $tip ) {
 			if ( is_array( $tip['link'] ) ) {
 				$cta_link = FrmAppHelper::maybe_add_missing_utm( $cta_link, $tip['link'] );
 			}
+
 			return $cta_link;
 		}
 
@@ -114,6 +115,7 @@ private static function cta_label() {
 		if ( $cta_text ) {
 			return $cta_text;
 		}
+
 		return FrmAddonsController::is_license_expired() ? __( 'Renew', 'formidable' ) : __( 'Upgrade to Pro.', 'formidable' );
 	}
 

classes/helpers/FrmXMLHelper.php

@@ -1246,6 +1246,7 @@ private static function maybe_prepare_json_view_content( $content ) {
 		if ( is_array( $maybe_decoded ) && isset( $maybe_decoded[0] ) && isset( $maybe_decoded[0]['box'] ) ) {
 			return FrmAppHelper::prepare_and_encode( $maybe_decoded );
 		}
+
 		return $content;
 	}
 
@@ -1827,6 +1828,7 @@ private static function default_field_options( $type ) {
 		if ( empty( $defaults['custom_html'] ) ) {
 			$defaults['custom_html'] = FrmFieldsHelper::get_default_html( $type );
 		}
+
 		return $defaults;
 	}
 
@@ -2440,6 +2442,7 @@ public static function get_supported_upload_file_types() {
 			// CSV Importing is only available in Pro.
 			$file_types[] = '.csv';
 		}
+
 		return $file_types;
 	}
 }

classes/models/FrmAntiSpam.php

@@ -212,6 +212,7 @@ public function validate() {
 				// add an exception for the entries page.
 				return true;
 			}
+
 			return $this->process_antispam_filter( $this->get_missing_token_message() );
 		}
 

classes/models/FrmApplicationTemplate.php

@@ -286,6 +286,7 @@ private function get_required_license() {
 		if ( 'plus' === $required_license ) {
 			$required_license = 'personal';
 		}
+
 		return $required_license;
 	}