Skip to content

Drop deprecated add_form_style_tab_options function and view#2774

Merged
Crabcyborg merged 1 commit into
masterfrom
drop_more_deprecated_code
Jan 12, 2026
Merged

Drop deprecated add_form_style_tab_options function and view#2774
Crabcyborg merged 1 commit into
masterfrom
drop_more_deprecated_code

Conversation

@Crabcyborg
Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 12, 2026

Walkthrough

This PR removes the deprecated add_form_style_tab_options() static method from FrmFormsController and its associated view file. The changes eliminate unused premium-feature education code that was previously marked for deprecation, totaling 18 lines removed across two files.

Changes

Cohort / File(s) Summary
Deprecated method removal
classes/controllers/FrmFormsController.php
Removed public static method add_form_style_tab_options() with PHPDoc and deprecation note; also removed the include statement for add_form_style_options.php
Deprecated view file removal
classes/views/frm-forms/add_form_style_options.php
Removed deprecated view file containing access guard and deprecation metadata

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess relevance to the changeset. Add a brief description explaining the purpose of removing these deprecated items and any context about the deprecation timeline.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: dropping a deprecated function and its associated view file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5a77051 and ad2ca94.

📒 Files selected for processing (2)
  • classes/controllers/FrmFormsController.php
  • classes/views/frm-forms/add_form_style_options.php
💤 Files with no reviewable changes (2)
  • classes/controllers/FrmFormsController.php
  • classes/views/frm-forms/add_form_style_options.php
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: PHP 8 tests in WP 6.9
  • GitHub Check: PHP 7.4 tests in WP 6.9
  • GitHub Check: PHP 7.4 tests in WP 6.9
  • GitHub Check: PHP 8 tests in WP 6.9
  • GitHub Check: Cypress
  • GitHub Check: Cypress
  • GitHub Check: Cypress
  • GitHub Check: PHP 8 tests in WP 6.9
  • GitHub Check: PHP 7.4 tests in WP 6.9

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Crabcyborg Crabcyborg merged commit 2770220 into master Jan 12, 2026
38 checks passed
@Crabcyborg Crabcyborg deleted the drop_more_deprecated_code branch January 12, 2026 13:50
stephywells pushed a commit that referenced this pull request Apr 4, 2026
Drop deprecated add_form_style_tab_options function and view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant