New sniff to change if else in loop to continue when if condition is …

[Crabcyborg]

…larger than else

Summary by CodeRabbit

• Refactor

  • Streamlined control flow and data handling across form formatting, CSV/repeater headings, metadata updates, and event processing to improve clarity and consistency.

• Chores

  • Added an automated code-analysis rule to detect and refactor end-of-loop conditional patterns.
  • Pinned a dev dependency version in the project manifest.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds a new PHP_CodeSniffer sniff that flips end-of-loop if/else blocks to use negated conditions with early continue, and applies this control-flow inversion across several helpers, models, and controllers to simplify first-occurrence handling and reduce nesting.

Changes

Cohort / File(s)	Summary
Code Analysis Sniff phpcs-sniffs/Formidable/Sniffs/CodeAnalysis/FlipLoopIfElseToContinueSniff.php, phpcs-sniffs/Formidable/ruleset.xml	New PHPCS sniff registered in the ruleset that detects large end-of-loop if blocks with small else blocks and auto-fixes by negating conditions, inserting continue, and dedenting code. Configurable thresholds: minIfLines, maxElseLines.
Helpers — duplicate-key & repeater handling classes/helpers/FrmAppHelper.php, classes/helpers/FrmCSVExportHelper.php	Inverted conditional flow to handle first-occurrence cases early (using continue), restructured aggregation for duplicate input names and repeater heading expansion; logic reordered but final data structures preserved.
Models — entry meta updates classes/models/FrmEntryMeta.php	update_entry_metas reorders checks to treat non-existent fields first (strict in_array), creating metas early and continuing; existing-field path then handles blanks or updates.
Square integration controllers square/controllers/FrmSquareLiteAppController.php, square/controllers/FrmSquareLiteEventsController.php	Flipped guards to early-continue on non-target cases (non-item_meta, non-object events); main processing now runs only for valid items/events.
Stripe integration — controllers & auth stripe/controllers/FrmStrpLiteEventsController.php, stripe/models/FrmStrpLiteAuth.php	Similar control-flow flips: early-continue for invalid events or non-item_meta; format_form_data reorders first-assignment vs aggregation for duplicate keys.
Tooling / dev deps composer.json	Tightened phpstan dev dependency from caret range to exact version (2.1.33).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• Make new sniffs better at negating conditions #2806 — Related changes to PHPCS condition-negation and operator-flipping logic in CodeAnalysis sniffs.
• Refine early return else sniff to also change functions with code bef… #2823 — Applies the same flip-if-to-continue refactor pattern across helper files.
• Improve early return sniff negating logic #2819 — Related edits to PHPCS sniff implementations for condition negation and operators.

Poem

🐰 I hopped through loops with nimble paws,
Flipped ifs to continues without a pause.
I negated conditions, tidied the nest,
Less nesting now — my code's well-dressed.
Hop, hop — refactor done, time for a rest! 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: introducing a new sniff that refactors if/else constructs in loops to use continue when the if block is larger than the else block.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}