New sniff to remove redundant empty on loop vars

[Crabcyborg]

Summary by CodeRabbit

• New Features

  • Added a code quality checker to detect and automatically fix redundant empty() validation on loop variables.

• Bug Fixes

  • Improved handling of the string value "0" which was previously treated as blank in certain form operations and data filtering scenarios.

• Chores

  • Updated code quality analysis rules for consistency.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR systematically replaces empty() checks with simpler truthiness checks (!$var) across multiple source files, and introduces a new PHP_CodeSniffer sniff to automatically detect and fix redundant empty() calls on foreach loop variables.

Changes

Cohort / File(s)	Summary
Source code truthiness checks classes/controllers/FrmEntriesController.php, classes/controllers/FrmXMLController.php, classes/helpers/FrmListHelper.php, classes/models/FrmEntry.php, classes/models/FrmInbox.php, classes/models/fields/FrmFieldCombo.php, classes/views/frm-fields/back-end/layout-classes.php, tests/phpunit/entries/test_FrmShowEntryShortcode.php	Replaced empty() checks with direct truthiness checks (!$var). Note: this treats values like the string "0" as truthy, which may have different behavior from prior empty() calls.
PHP_CodeSniffer sniff phpcs-sniffs/Formidable/Sniffs/CodeAnalysis/RedundantEmptyOnLoopVariableSniff.php	New sniff implementation (+298 lines) that detects redundant empty() calls on foreach loop variables and auto-fixes them. Includes token-level AST traversal, loop variable detection, reassignment tracking, and whitespace-aware transformations.
Sniffs ruleset phpcs-sniffs/Formidable/ruleset.xml	Removed RedundantParentheses rule; added RedundantEmptyOnLoopVariable and RedundantIntermediateVariable CodeAnalysis rules.

Possibly related PRs

• Simplify some array checks #2722: Performs the same code-level change pattern—replacing empty() checks with truthiness checks—across overlapping files.
• Update redundant empty sniff to also catch conditions with && and || #2758: Addresses redundant empty() usage by adding/updating PHP_CodeSniffer rules for empty() replacements with matching code changes.
• Move formidable sniffs to separate ruleset file #2801: Modifies phpcs-sniffs ruleset and sniffs, overlapping on rule additions and sniff configuration.

Poem

🐰 A rabbit hops through empty() calls so deep,
Replacing them with truthiness so sweet,
A sniff that catches loops from end to start,
Making the code cleaner, pure art! ✨

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: introducing a new PHP_CodeSniffer sniff that detects and removes redundant empty() calls on foreach loop variables.
Docstring Coverage	✅ Passed	Docstring coverage is 92.86% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In
`@phpcs-sniffs/Formidable/Sniffs/CodeAnalysis/RedundantEmptyOnLoopVariableSniff.php`:
- Around line 186-207: The current wasVariableReassigned function only detects
simple T_EQUAL and misses compound assignments and increments/decrements; update
it to also treat compound-assignment tokens (e.g. T_PLUS_EQUAL, T_MINUS_EQUAL,
T_MUL_EQUAL, T_DIV_EQUAL, T_CONCAT_EQUAL, T_MOD_EQUAL, T_POW_EQUAL, T_AND_EQUAL,
T_OR_EQUAL, T_XOR_EQUAL, T_SL_EQUAL, T_SR_EQUAL) as reassignment when they
appear immediately after the variable, and detect increment/decrement tokens
(T_INC, T_DEC) when they appear immediately before or after the variable;
implement this by examining the next non-whitespace token for any
assignment/compound-assignment token and the previous/next non-whitespace token
for T_INC/T_DEC (and treat =&/reference-style assignments similarly if present)
inside wasVariableReassigned to return true for these cases.

🧹 Nitpick comments (1)

phpcs-sniffs/Formidable/Sniffs/CodeAnalysis/RedundantEmptyOnLoopVariableSniff.php (1)

220-220: Unused parameter $variableName in applyFix method.

The $variableName parameter is passed but never used. The method independently locates the variable token using findNext. Consider removing this parameter to clean up the API.

Proposed fix

Update the method signature and call site:

-private function applyFix( File $phpcsFile, $emptyToken, $openParen, $closeParen, $variableName ) {
+private function applyFix( File $phpcsFile, $emptyToken, $openParen, $closeParen ) {

And at line 110:

-$this->applyFix( $phpcsFile, $stackPtr, $openParen, $closeParen, $variableName );
+$this->applyFix( $phpcsFile, $stackPtr, $openParen, $closeParen );