Skip to content

New sniff to prevent empty on function responses #2850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 4 commits into from
Jan 20, 2026
Merged

New sniff to prevent empty on function responses #2850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aabe2df
New sniff to prevent empty on function responses
Crabcyborg Jan 20, 2026
f674809
revert change
Crabcyborg Jan 20, 2026
ae35f88
Update sniff
Crabcyborg Jan 20, 2026
8c9c1ca
Run php cs fixer
Crabcyborg Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion classes/controllers/FrmAddonsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1362,7 +1362,7 @@ public static function install_addon_api() {
}

// If empty license, save it now.
if ( empty( self::get_pro_license() ) && function_exists( 'load_formidable_pro' ) ) {
if ( ! self::get_pro_license() && function_exists( 'load_formidable_pro' ) ) {
load_formidable_pro();
$license = stripslashes( FrmAppHelper::get_param( 'key', '', 'request', 'sanitize_text_field' ) );

Expand Down
2 changes: 1 addition & 1 deletion classes/models/FrmSolution.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,7 +726,7 @@ protected function show_page_links( $step ) {
*/
protected function is_current_plugin() {
$to_redirect = get_transient( FrmOnboardingWizardController::TRANSIENT_NAME );
return $to_redirect === $this->plugin_slug && empty( $this->is_complete() );
return $to_redirect === $this->plugin_slug && ! $this->is_complete();
}

/**
Expand Down
2 changes: 1 addition & 1 deletion classes/views/styles/_buttons.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ class="frm-style-item-heading">
$frm_style->get_field_name( 'submit_style' ),
array(
'div_class' => 'with_frm_style frm_toggle',
'checked' => empty( $frm_style->get_field_name( 'submit_style' ) ),
'checked' => ! $frm_style->get_field_name( 'submit_style' ),
'echo' => true,
'aria-label-attr' => __( 'Disable submit button styling', 'formidable' ),
)
Expand Down
14 changes: 7 additions & 7 deletions classes/views/styles/components/FrmSliderStyleComponent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public function __construct( $field_name, $field_value, $data ) {
$this->data['unit_measurement'] = $this->detect_unit_measurement();
$this->data['has-multiple-values'] = count( $this->get_values() ) > 1;
$this->data['units'] = $this->get_units_list( $data );
$this->data['value_label'] = empty( $this->detect_unit_measurement() ) ? $field_value : (float) $field_value;
$this->data['value_label'] = ! $this->detect_unit_measurement() ? $field_value : (float) $field_value;

$this->init_defaults();
$this->init_icon();
Expand Down Expand Up @@ -97,32 +97,32 @@ private function init_multiple_values() {

$this->data['vertical'] = array(
'unit' => $this->detect_unit_measurement( $top ),
'value' => empty( $this->detect_unit_measurement( $top ) ) ? $top : (float) $top,
'value' => ! $this->detect_unit_measurement( $top ) ? $top : (float) $top,
);

$this->data['horizontal'] = array(
'unit' => $this->detect_unit_measurement( $right ),
'value' => empty( $this->detect_unit_measurement( $right ) ) ? $right : (float) $right,
'value' => ! $this->detect_unit_measurement( $right ) ? $right : (float) $right,
);

$this->data['top'] = array(
'unit' => $this->detect_unit_measurement( $top ),
'value' => empty( $this->detect_unit_measurement( $top ) ) ? $top : (float) $top,
'value' => ! $this->detect_unit_measurement( $top ) ? $top : (float) $top,
);

$this->data['bottom'] = array(
'unit' => $this->detect_unit_measurement( $bottom ),
'value' => empty( $this->detect_unit_measurement( $bottom ) ) ? $bottom : (float) $bottom,
'value' => ! $this->detect_unit_measurement( $bottom ) ? $bottom : (float) $bottom,
);

$this->data['left'] = array(
'unit' => $this->detect_unit_measurement( $left ),
'value' => empty( $this->detect_unit_measurement( $left ) ) ? $left : (float) $left,
'value' => ! $this->detect_unit_measurement( $left ) ? $left : (float) $left,
);

$this->data['right'] = array(
'unit' => $this->detect_unit_measurement( $right ),
'value' => empty( $this->detect_unit_measurement( $right ) ) ? $right : (float) $right,
'value' => ! $this->detect_unit_measurement( $right ) ? $right : (float) $right,
);
}

Expand Down
Loading