Update sniff to catch more early returns

[Crabcyborg]

Summary by CodeRabbit

Release Notes

• Bug Fixes

  • Improved form filter accessibility on the entries list by adding screen reader labels and reorganizing filter controls for better usability with assistive technologies

• Improvements

  • Optimized form import processing workflow to enhance reliability and consistency

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Three files undergo refactoring: a helper for entry list navigation applies guard logic inversion and adds accessibility labels; an XML helper adopts an early-return pattern for form import logic; and a PHP_CodeSniffer sniff extends to detect early-return opportunities after up to three simple assignment statements.

Changes

Cohort / File(s)	Summary
Accessibility and UI Refactoring classes/helpers/FrmEntriesListHelper.php	Inverts guard logic to exit early when not on top tab or form_id is present. Adds screen-reader-only label for form filter. Reorganizes DOM structure to keep forms dropdown and filter button in same container without changing external behavior.
Control Flow Refactoring classes/helpers/FrmXMLHelper.php	Replaces nested conditional with early-return guard pattern. When form is missing or old_style is not set, function returns early; otherwise, casts form to array, updates custom_style, re-invokes import updater, computes has_changed check, and applies form update.
CodeSniffer Sniff Enhancement phpcs-sniffs/Formidable/Sniffs/CodeAnalysis/FlipIfToEarlyReturnSniff.php	Extends sniff to detect if statements appearing after up to three simple assignment statements. Adds findIfAfterSimpleSetup() helper to skip whitespace and assignments; adds isSimpleAssignment() helper to validate assignment patterns. Adjusts control flow to use either initial if or if found after setup.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• New sniff to remove extra white space before closing brace #2807: Modifies the same FlipIfToEarlyReturnSniff.php file, indicating parallel or sequential sniff enhancements.
• New sniff to add early returns to functions that are one big if #2803: Introduced the original FlipIfToEarlyReturnSniff that this PR extends with new pattern detection capabilities.
• Add new early return sniff when function is just a return var declara… #2851: Adds a related FlipIfToEarlyReturnInitialValueSniff for detecting similar early-return opportunities in a complementary pattern.

Poem

🐰 Guards flip and returns flow early and bright,
Assignments we skip, then patterns take flight!
Screen-readers now hear what was silent before,
The sniff sees deeper—what helpers explore! ✨

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}