Skip to content

Use eslint 9 #2961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crabcyborg merged 11 commits into from
Feb 18, 2026
Merged

Use eslint 9 #2961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7051ba2
Use eslint 9
Crabcyborg Feb 18, 2026
34c9c3b
Remove extra whitespace
Crabcyborg Feb 18, 2026
7148630
Remove more whitespace
Crabcyborg Feb 18, 2026
266cda9
Add new whitespace rules and fix
Crabcyborg Feb 18, 2026
f08e58f
Update more packages
Crabcyborg Feb 18, 2026
17e089c
Update more packages
Crabcyborg Feb 18, 2026
7f8088f
Prefer returns now over return
Crabcyborg Feb 18, 2026
d7114b5
Stop referencing duplicate key
Crabcyborg Feb 18, 2026
26e295e
Change stylelint workflow after updating versions
Crabcyborg Feb 18, 2026
0dd61bf
Refer append over appendchild
Crabcyborg Feb 18, 2026
1474485
Fix eslint issue
Crabcyborg Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions .eslintignore
View file
Open in desktop

This file was deleted.

229 changes: 0 additions & 229 deletions .eslintrc.json
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions .github/workflows/jscs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v5
with:
node-version: "20.10.0"
node-version: "22"

- name: Cache dependencies
id: cache-npm
Expand All @@ -34,7 +34,7 @@ jobs:

- name: Install dependencies
if: steps.cache-npm.outputs.cache-hit != 'true'
run: npm ci --include=dev
run: npm ci --include=dev --legacy-peer-deps

- name: Run ESLint
run: ./node_modules/.bin/eslint .
4 changes: 2 additions & 2 deletions .github/workflows/stylelint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v5
with:
node-version: "20.10.0"
node-version: "22"

- name: Cache dependencies
id: cache-npm
Expand All @@ -34,7 +34,7 @@ jobs:

- name: Install dependencies
if: steps.cache-npm.outputs.cache-hit != 'true'
run: npm ci --include=dev
run: npm ci --include=dev --legacy-peer-deps

- name: Run Stylelint
run: npx stylelint "**/*.{css,scss}"
4 changes: 2 additions & 2 deletions .stylelintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@
"ignoreFunctions": ["currentColor"]
}
],
"max-line-length": null,
"color-named": null,
"declaration-property-unit-allowed-list": null,
"no-invalid-position-at-import-rule": null,
"font-family-no-missing-generic-family-keyword": null,
"scss/at-import-no-partial-leading-underscore": null
"scss/at-import-no-partial-leading-underscore": null,
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check stylelint-scss version in package.json
fd --type f "package.json" --max-depth 1 --exec cat {} \; | grep -A 2 -B 2 '"stylelint-scss"'

Repository: Strategy11/formidable-forms

Length of output: 53

🏁 Script executed:

#!/bin/bash
# Read .stylelintrc.json around lines 30-35 to see both rules in context
head -40 .stylelintrc.json | tail -15

Repository: Strategy11/formidable-forms

Length of output: 484

🏁 Script executed:

#!/bin/bash
# Try a simpler approach to find package.json and stylelint-scss version
find . -maxdepth 2 -name "package.json" -type f -exec cat {} \; 2>/dev/null | python3 << 'EOF'
import json
import sys
try:
    data = json.load(sys.stdin)
    if 'devDependencies' in data and 'stylelint-scss' in data['devDependencies']:
        print(f"stylelint-scss version: {data['devDependencies']['stylelint-scss']}")
    elif 'dependencies' in data and 'stylelint-scss' in data['dependencies']:
        print(f"stylelint-scss version: {data['dependencies']['stylelint-scss']}")
    else:
        print("stylelint-scss not found in dependencies")
except json.JSONDecodeError:
    print("Error parsing JSON")
EOF

Repository: Strategy11/formidable-forms

Length of output: 89

🌐 Web query:

stylelint-scss deprecation "at-import-no-partial-leading-underscore" v6.0

💡 Result:

scss/at-import-no-partial-leading-underscore is deprecated (it was deprecated when scss/load-no-partial-leading-underscore was introduced) and you should migrate to:

  • scss/load-no-partial-leading-underscore (covers @import, @use, @forward, and meta.load-css) [1], [2]

It was not removed in v6.0—it remained available (but deprecated) throughout the v6.x line; the deprecated at-import-* rules were removed in v7.0.0 [3]. If you saw a warning mentioning “removed in v6.0”, that aligns with a known issue: in v6.2.0 they fixed the version number in the deprecation message for at-import-no-partial-leading-underscore [4].

Migration (Stylelint config):

  • Replace "scss/at-import-no-partial-leading-underscore": true
  • With "scss/load-no-partial-leading-underscore": true [1], [2]

Sources: [1] [2] [3] [4]

🏁 Script executed:

#!/bin/bash
# Simple grep approach for stylelint-scss version
grep -r "stylelint-scss" package.json 2>/dev/null || echo "Could not find stylelint-scss version"

Repository: Strategy11/formidable-forms

Length of output: 108

Remove the deprecated scss/at-import-no-partial-leading-underscore rule.

at-import-no-partial-leading-underscore is deprecated and will be removed in v7.0.0; the replacement is load-no-partial-leading-underscore. Since line 33 already includes the replacement rule, line 32 is redundant and should be removed.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.stylelintrc.json at line 32, Remove the deprecated scss rule
"scss/at-import-no-partial-leading-underscore" from the .stylelintrc.json
configuration (it is redundant because the replacement
"scss/load-no-partial-leading-underscore" is already present); simply delete the
"scss/at-import-no-partial-leading-underscore" entry so only
"scss/load-no-partial-leading-underscore" remains.

"scss/load-no-partial-leading-underscore": null
}
}
Loading
Loading