-
Notifications
You must be signed in to change notification settings - Fork 41
Rock/form actions a11y keyboard nav #3078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Crabcyborg
merged 14 commits into
rock/form-actions-refresh
from
rock/form-actions-a11y-keyboard-nav
Apr 27, 2026
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d40a5a8
enhance(form-actions): add tabindex for accessibility and improve foc…
shervElmi 2a7f23d
feat(focus): add focus-outline mixin for improved accessibility styles
shervElmi c05bc56
style(form-actions): enhance focus styles by adding focus-outline mix…
shervElmi 82190dc
feat(tabs-navigator): enhance accessibility by adding ARIA roles and …
shervElmi 52eb87a
feat(admin): add keyboard navigation support for form actions to enha…
shervElmi bcd39d1
refactor(admin): simplify arrow function syntax and improve code read…
shervElmi 3434e61
refactor(admin): replace Array constructor with new Array for improve…
shervElmi fe6c274
refactor(admin): optimize getUniqueActionTitle function for better pe…
shervElmi ea4a491
npm run build
shervElmi 69d7148
Merge remote-tracking branch 'origin/rock/form-actions-refresh' into …
shervElmi dd9ed2d
npm run build
shervElmi fcf5e82
Merge branch 'rock/form-actions-refresh' into rock/form-actions-a11y-…
shervElmi 75642a0
npm run build
shervElmi 5f28e5a
Merge branch 'rock/form-actions-refresh' into rock/form-actions-a11y-…
Crabcyborg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| @mixin focus-outline( | ||
| $width: 1px, | ||
| $offset: 2px, | ||
| $color: var(--primary-500), | ||
| $radius: null | ||
| ) { | ||
|
|
||
| &:focus-visible { | ||
| outline: $width solid $color; | ||
| outline-offset: $offset; | ||
|
|
||
| @if $radius { | ||
| border-radius: $radius; | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.