Skip to content

Fix pro isuse 6456#3096

Open
Crabcyborg wants to merge 1 commit into
masterfrom
pro_issue_6456
Open

Fix pro isuse 6456#3096
Crabcyborg wants to merge 1 commit into
masterfrom
pro_issue_6456

Conversation

@Crabcyborg
Copy link
Copy Markdown
Contributor

@Crabcyborg Crabcyborg commented May 14, 2026

Fixes https://github.com/Strategy11/formidable-pro/issues/6456

Summary by CodeRabbit

  • Bug Fixes
    • Improved form field label display for field groups containing more than 6 fields to ensure correct visibility behavior.

Review Change Stack

@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented May 14, 2026

DeepSource Code Review

We reviewed changes in f42ed06...08e6069 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP May 14, 2026 11:24a.m. Review ↗
JavaScript May 14, 2026 11:24a.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: efa82547-feac-463b-b329-755a23e2afd6

📥 Commits

Reviewing files that changed from the base of the PR and between f42ed06 and 08e6069.

📒 Files selected for processing (2)
  • css/frm_admin.css
  • resources/scss/admin/components/form/_form-field.scss

📝 Walkthrough

Walkthrough

A single SCSS selector in the form field styling is refined to more specifically target the field ID label hiding rule. The selector is narrowed from a broad ancestor match to a more precise nested structure match when field groups exceed 6 items.

Changes

Field ID Label Selector Refinement

Layer / File(s) Summary
Field ID label selector refinement
resources/scss/admin/components/form/_form-field.scss
The CSS selector hiding .frm-sub-label.frm-field-id is narrowed to target the nested .frm_grid_container/.frm_inner_field_container structure within #frm-show-fields using :has(> li:nth-child(7)) when field groups exceed 6 items.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A selector springs with focus keen,
Specificity sharpens the CSS scene,
Six fields or fewer, the label stays bright,
Seven or more, it fades from sight! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title contains a typo ('isuse' instead of 'issue') and is not descriptive of the actual changes made to the codebase. Update the title to be more descriptive and fix the typo, e.g., 'Fix SCSS selector for form field labels in groups with 7+ fields' or 'Fix pro issue 6456: Hide sub-labels in large field groups'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pro_issue_6456

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Crabcyborg Crabcyborg requested a review from garretlaxton May 14, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant