JM: fix cursor pagination with NULL values#43
Merged
Conversation
Extends COALESCE handling from falsyBool columns to all nullable real columns to prevent NULL comparison issues in cursor WHERE clauses
marcinmosiejko
force-pushed
the
cursor-pagination-fix
branch
from
802340e to
05ffa89
Compare
marcinmosiejko
force-pushed
the
cursor-pagination-fix
branch
2 times, most recently
from
1a6917f to
bf6b0e4
Compare
marcinmosiejko
force-pushed
the
cursor-pagination-fix
branch
from
bf6b0e4 to
9ee8be2
Compare
Replace timing-dependent test with robust Promise.allSettled approach that handles all possible race condition outcomes gracefully. - Test now verifies system consistency rather than exact timing - Handles both scenarios: changeId first vs set first - Eliminates CI flakiness while maintaining test coverage
wmertens
approved these changes
Aug 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends COALESCE handling from falsyBool columns to all nullable real columns to prevent NULL comparison issues in cursor WHERE clauses