[FIX] Include missing events in skippable array #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added events that should be skipped as they don't add widgets to the queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some events that should be included in the skippable array, as they don't add widgets to the queue (#28):
"event": received with every real event (i.e. the equivalent in production of"event:test")"alertService:toggleSound": received when alerts are muted/unmuted in the Activity Feed or within the editor"delete-message","delete-messages": received when chat messages are deletedPublished widgets that use the skippable list should be updated too, but I'd rather leave that to widget owners/repo maintainers