fix: Add playback click event handling in WebEngineView#423
Open
ptfpinho23 wants to merge 1 commit into
Open
Conversation
- attach click event listeners onto embedded video element to control playback - add observer to dynamically reapply listeners, whenever DOM updates/changes - wrap `shellEvents.emit` to reapply listeners on `availabilityChanged` - Improve error handling to prevent attaching duplicate attachments
Author
|
@kKaskak whenever you have some time - could you double check the above? Would this be interesting to be merged? Shall we close? - my wife's been begging for this for quiet some time to be included on a release lol |
Member
Does v5 have this issue? |
|
I'd like to know if there is any reason why this hasn't been merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the issue where playback controls - play & pause - were not working in the stremio desktop apps. The problem - as stated in the issue - stems from click events on the
<video>element not being propagated correctly withinWebEngineViewQML.Changes made:
shellEvents.emitto reapply listeners onavailabilityChangedTesting Steps
fix - #422