This repository was archived by the owner on Sep 1, 2025. It is now read-only.
Handles OAuth2.Error #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eparreno
approved these changes
Jul 29, 2019
The OAuth library can return also this, and not only an OAuth2.Response: https://hexdocs.pm/oauth2/0.9.4/OAuth2.Client.html#get_token/4 This patch adds handling for both cases of error result.
jaimeiniesta
force-pushed
the
handle-oauth-errors
branch
from
54cbc52 to
b42ff16
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OAuth library can return also this, and not only an OAuth2.Response:
https://hexdocs.pm/oauth2/0.9.4/OAuth2.Client.html#get_token/4
This patch adds handling for both cases of error result.