Feature/update sublime adapter#21
Merged
SublimeLeo merged 4 commits intosublime-adapterfrom Mar 13, 2020
Merged
Conversation
SublimeLeo
force-pushed
the
feature/update-sublime-adapter
branch
from
599a8a5 to
c348824
Compare
SublimeLeo
force-pushed
the
sublime-adapter
branch
from
55bac12 to
451dacb
Compare
fgcloutier
approved these changes
Mar 12, 2020
ghourlier
approved these changes
Mar 13, 2020
SublimeJeremy
approved these changes
Mar 13, 2020
SublimeLeo
added a commit
that referenced
this pull request
Apr 7, 2020
* Update sublimeBidAdapter to 0.5.1 * Add tests for private functions * Remove window.sublime * Update pixel name for bid event
SublimeLeo
added a commit
that referenced
this pull request
Apr 8, 2020
* add prebid version of adapter * Feature/update sublime adapter (#21) * Update sublimeBidAdapter to 0.5.1 * Add tests for private functions * Remove window.sublime * Update pixel name for bid event * Remove pixels on non-event and add onBidWon * Incremente version of sublimeBidAdapter * Renamed pixel for timeout and introduce gvlid * Remove unnecessary params for sendEvent Co-Authored-By: fgcloutier <fg.cloutier@sublimeskinz.com> Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com> Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>
fgcloutier
added a commit
that referenced
this pull request
Sep 4, 2020
* add prebid version of adapter * Feature/update sublime adapter (#21) * Update sublimeBidAdapter to 0.5.1 * Add tests for private functions * Remove window.sublime * Update pixel name for bid event * Remove pixels on non-event and add onBidWon (#22) * add prebid version of adapter * Feature/update sublime adapter (#21) * Update sublimeBidAdapter to 0.5.1 * Add tests for private functions * Remove window.sublime * Update pixel name for bid event * Remove pixels on non-event and add onBidWon * Incremente version of sublimeBidAdapter * Renamed pixel for timeout and introduce gvlid * Remove unnecessary params for sendEvent Co-Authored-By: fgcloutier <fg.cloutier@sublimeskinz.com> Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com> Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com> * Remove trailing-space * Fix version in tests Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com> Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com>
o3LL
pushed a commit
that referenced
this pull request
Jun 1, 2021
prebid#6442) * add prebid version of adapter * Feature/update sublime adapter (#21) * Update sublimeBidAdapter to 0.5.1 * Add tests for private functions * Remove window.sublime * Update pixel name for bid event * Remove pixels on non-event and add onBidWon (#22) * add prebid version of adapter * Feature/update sublime adapter (#21) * Update sublimeBidAdapter to 0.5.1 * Add tests for private functions * Remove window.sublime * Update pixel name for bid event * Remove pixels on non-event and add onBidWon * Incremente version of sublimeBidAdapter * Renamed pixel for timeout and introduce gvlid * Remove unnecessary params for sendEvent Co-Authored-By: fgcloutier <fg.cloutier@sublimeskinz.com> Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com> Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com> * Remove trailing-space * Fix version in tests * sublimeAdapter: Improve pixels data * sublimeAdapter: Update tests * sublimeAdapter: Rename data Co-authored-by: Gaby <gaby.hourlier@sublimeskinz.com> Co-authored-by: Léo <51166933+SublimeLeo@users.noreply.github.com> Co-authored-by: fgcloutier <fg.cloutier@sublimeskinz.com> Co-authored-by: Léo GRAND <leo.grand@sublimeskinz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Changes:
Test parameters for validating bids