feat(sublimeBidAdapter): modifying bid request contentType#25
Open
fgcloutier wants to merge 4 commits intosublime-adapter-bundlefrom
Open
feat(sublimeBidAdapter): modifying bid request contentType#25fgcloutier wants to merge 4 commits intosublime-adapter-bundlefrom
fgcloutier wants to merge 4 commits intosublime-adapter-bundlefrom
Conversation
JeremiePat
reviewed
Dec 3, 2020
| const DEFAULT_TTL = 600; | ||
| const SUBLIME_ANTENNA = 'antenna.ayads.co'; | ||
| const SUBLIME_VERSION = '0.5.2-bundle'; | ||
| const SUBLIME_VERSION = '0.6.1-bundle'; |
There was a problem hiding this comment.
On ne serait pas plutôt sur une version 0.7.0 ? (pour être raccord avec le nouvel adapter)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
How to test
check that
gulp test --file test/spec/modules/sublimeBidAdapter_spec.jsis green;
execute:
gulp serve-fast --modules=appnexusBidAdapter,sublimeBidAdapter`This will compile prebid.js, launch a test server and run the tests.
Other information
https://sublimeskinz.atlassian.net/browse/DL-1476